Skip to content

Feature/file upload #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Feature/file upload #214

wants to merge 13 commits into from

Conversation

bqle
Copy link
Contributor

@bqle bqle commented May 26, 2022

Students can now upload files and delete files associated with questions.

@bqle bqle requested review from ArmaanT and kevc528 May 26, 2022 09:39
@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Base: 99.01% // Head: 98.42% // Decreases project coverage by -0.58% ⚠️

Coverage data is based on head (b245f72) compared to base (f73ec90).
Patch coverage: 90.32% of modified lines in pull request are covered.

❗ Current head b245f72 differs from pull request most recent head bb8137e. Consider uploading reports for the commit bb8137e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
- Coverage   99.01%   98.42%   -0.59%     
==========================================
  Files          25       26       +1     
  Lines        1316     1395      +79     
==========================================
+ Hits         1303     1373      +70     
- Misses         13       22       +9     
Flag Coverage Δ
backend 98.42% <90.32%> (-0.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
backend/ohq/management/commands/createcourse.py 100.00% <ø> (ø)
backend/ohq/statistics.py 100.00% <ø> (ø)
backend/ohq/admin.py 85.00% <83.33%> (-15.00%) ⬇️
backend/ohq/permissions.py 98.30% <85.71%> (-0.81%) ⬇️
backend/ohq/views.py 97.88% <90.00%> (-1.30%) ⬇️
backend/ohq/forms.py 100.00% <100.00%> (ø)
backend/ohq/models.py 100.00% <100.00%> (ø)
backend/ohq/serializers.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment on lines +354 to +356
question_file = QuestionFile(question=question, file=uploaded_file)
question_file.save()
return question_file
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this automatically save to S3 instead of local?

@trangiabach trangiabach requested review from benjmnxu and removed request for benjmnxu January 28, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant