Skip to content

🐛 Bug Fix for Queue Settings Pin Toggle #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryantanen merged 2 commits into from
Feb 13, 2025
Merged

🐛 Bug Fix for Queue Settings Pin Toggle #325

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f9e637
:bug: Fixed a issue with Queue settings which did not allow users to …
ryantanen Feb 12, 2025
8d0659b
Refactored QueueFormField to make easier to read
ryantanen Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 11 additions & 18 deletions frontend/components/Course/InstructorQueuePage/QueueFormFields.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,12 +172,14 @@ const QueueFormFields = ({
}
setInput({ ...input });
};

const handlePinInputChange = (e, { checked }) => {
input.pinEnabled = checked;
setInput({ ...input });
};
/* PROPS UPDATE */
// Helper function to handle toggle changes
const handleToggleChange = (name: string) => {
setInput({
...input,
[name]: !input[name],
});
};

return (
<>
Expand Down Expand Up @@ -246,7 +248,7 @@ const QueueFormFields = ({
id="pin-toggle"
toggle
disabled={loading}
onChange={handlePinInputChange}
onClick={() => handleToggleChange("pinEnabled")}
/>
</Form.Field>

Expand All @@ -261,14 +263,9 @@ const QueueFormFields = ({
name="rateLimitEnabled"
id="rate-limit-toggle"
toggle
defaultChecked={input.rateLimitEnabled}
checked={input.rateLimitEnabled}
label="Enable queue rate-limiting"
onChange={() =>
setInput({
...input,
rateLimitEnabled: !input.rateLimitEnabled,
})
}
onClick={() => handleToggleChange("rateLimitEnabled")}
/>

{input.rateLimitEnabled && (
Expand Down Expand Up @@ -382,11 +379,7 @@ const QueueFormFields = ({
toggle
label="Enable a countdown for questions"
onChange={() =>
setInput({
...input,
questionTimerEnabled:
!input.questionTimerEnabled,
})
handleToggleChange("questionTimerEnabled")
}
/>
</Form.Field>
Expand Down
Loading