Skip to content

Make uv a dependency manager option #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 19, 2025
Merged

Make uv a dependency manager option #327

merged 8 commits into from
Mar 19, 2025

Conversation

clay53
Copy link
Contributor

@clay53 clay53 commented Feb 16, 2025

No description provided.

@clay53
Copy link
Contributor Author

clay53 commented Mar 5, 2025

Rebased on #329 for testing purposes

@clay53
Copy link
Contributor Author

clay53 commented Mar 5, 2025

Rebased on #329 again. UV migrations for local development and the production-like docker image work now. Since django-base has not been updated, it is currently installing uv within the ohq container. uv and pipenv are still available for both dev and docker images. For docker images to use pipenv instead of the new default, uv, must set DEPENDENCY_MANAGER docker arg to pipenv. uv is the default so that will be used in prod without having to change and prod settings, but can be rolled back to use pipenv in case of failure.

@clay53 clay53 changed the title uv migration Make uv the default dependency manager Mar 5, 2025
@clay53 clay53 requested a review from joyliu-q March 5, 2025 16:58
@clay53 clay53 changed the base branch from master to proddev March 5, 2025 20:29
@clay53 clay53 marked this pull request as ready for review March 5, 2025 20:29
Copy link
Contributor

@joyliu-q joyliu-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few changes! thanks for the pr :D

@clay53 clay53 requested a review from joyliu-q March 16, 2025 02:40
@clay53 clay53 changed the title Make uv the default dependency manager Make uv a dependency manager option Mar 16, 2025
Copy link
Contributor

@joyliu-q joyliu-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@clay53 clay53 merged commit 64b4d9b into proddev Mar 19, 2025
3 of 5 checks passed
@clay53 clay53 deleted the uv-migration branch March 19, 2025 15:32
clay53 added a commit that referenced this pull request Mar 22, 2025
* Migrate dev environment to uv

* Migrate docker setup to uv

* Move instead of copy uv-installed binaries

* Move .dockerignore .venv from uv section to misc

* Revert default dependency manager back to pipenv for docker images

* Install uv in a simpler way in docker

* Merge project dependency copy in backend docker

* Simplify pipenv or uv install in docker
joyliu-q pushed a commit that referenced this pull request Mar 28, 2025
* Add docker compose profile for emulating production

* Comments for proddev changes

* Add instruction for using proddev to README

* Turn off Debug for proddev so it works

* Add connect instructions to README

* Make uv a dependency manager option (#327)

* Migrate dev environment to uv

* Migrate docker setup to uv

* Move instead of copy uv-installed binaries

* Move .dockerignore .venv from uv section to misc

* Revert default dependency manager back to pipenv for docker images

* Install uv in a simpler way in docker

* Merge project dependency copy in backend docker

* Simplify pipenv or uv install in docker

* Add project name to pyproject.toml

* Make uv default for prod

* Remove name from pyproject.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants