Add backend for bookable office hours #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dkwncho
commented
Mar 30, 2025
dkwncho
commented
- Created new Booking model, serializer, permission, urls, and viewset
- Bookings can only be created with start times of 5-minute intervals (e.g., :00, :05, :10, :15, etc), would need to reflect this on the frontend
- Created new Booking model, serializer, permission, urls, and viewset
- Removed interval limitations (old change that should not have been here) - Now properly handles when interval is null (i.e. when occurrence is not a bookable event)
- Also added potentially reasonable validation checks for booking times
- Added a default value for params field of Rule object since it can be blank
- Removed automatic Booking object creation upon Occurrence object creation - Split up BookingViewSet and updated booking url patterns for cleaner interaction with booking objects - Refactored BookingPermission for readability and to reflect the above changes
… fields actually exist
There was a problem hiding this comment.
Pull Request Overview
This PR adds the backend functionality for bookable office hours by introducing a new Booking model along with its serializers, views, permissions, tests, and corresponding migration.
- Introduces the Booking model with its validations and integration into existing scheduling functionality.
- Adds new viewsets, permissions, and serializers to support booking creation, retrieval, updating, and deletion.
- Updates test suites and URLs to cover the new booking functionality.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| backend/tests/ohq/test_permissions.py | Added booking tests and updated start/end times for consistency. |
| backend/tests/ohq/test_models.py | Added tests for booking validations and overlapping bookings. |
| backend/ohq/views.py | Introduced BookingDetailViewSet and BookingListCreateViewSet. |
| backend/ohq/urls.py | Registered booking viewsets and nested routes for occurrences. |
| backend/ohq/serializers.py | Added BookingSerializer and updated OccurrenceSerializer fields. |
| backend/ohq/permissions.py | Added BookingPermission for booking access control. |
| backend/ohq/models.py | Created the Booking model with time interval and overlap check. |
| backend/ohq/migrations/0022_booking.py | Migration file for the new Booking model. |
| backend/ohq/admin.py | Registered Booking in the admin interface. |
| backend/Pipfile | Updated dependency from django-schedules-ohq to django-scheduler. |
joyliu-q
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.