Frontend/sublet map#61
Merged
Merged
Conversation
jamesdoh0109
requested changes
Mar 29, 2026
Collaborator
jamesdoh0109
left a comment
There was a problem hiding this comment.
In serializers.py, for SubletDataSerializer, change to
class Meta:
model = Sublet
fields = [
"street_address",
"beds",
"baths",
"start_date",
"end_date",
"latitude",
"longitude",
]
def get_latitude(self, obj):
approx_lat, _ = obj.approximate_location
if approx_lat is not None:
return float(approx_lat)
return None
def get_longitude(self, obj):
_, approx_lon = obj.approximate_location
if approx_lon is not None:
return float(approx_lon)
return None
``
jamesdoh0109
approved these changes
Mar 30, 2026
Collaborator
There was a problem hiding this comment.
This is very very nit, but this change is out of scope with the PR since this touches backend. Totally fine for now, but generally you want the scope of a PR to focus on a single thing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a map on the sublet page to display approx location