Jackyf/refactor news merge (?)#593
Open
innocentoak wants to merge 15 commits into
Open
Conversation
1) ExternalNewsView replaces NewsViewController (3 segmented news view) 2) NewsWebView is used in ExternalNewsView to have the individual WebViews for each tab of the segmented control 3) NewsDetailView replaces NativeViewController in having new styling that replicates that of NY Times and Washington Post 4) Removes old reference to NewsArticle model
…o its own file for sake of collating all relevant News files
…ewsDetailView, and also reference to NewsCardView that is now in its own separate file
…troller again) and add the navigation to it from Features
… able to use it in NewsDetailView
…ilView in NewsDetailView
…king up full space
1) HomeNewsCell 2) HomeNewsCEllItem 3) NativeNewsViewController
…p still compiles 1) HomePostCell 2) HomePostCellItem 3) HomeViewController + Delegates 4) HomeItemTypes 5) ControllerModel
…from the nuke 1) HomePostCell 2) HomePostCellitem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe just review the files I nuked to see if there is dependencies on them elsewhere in the app.
From what I've seen the app still compiles and runs like normal, and even more files could possibly be nuked.