Migrate authentication to LabsPlatformSwift

[jonathanmelitski]

LabsPlatformSwift is a new package that can handle the authentication flow with the Penn Labs Platform server. It handles the general authentication flow and all network-related requests to the Penn Labs servers (all network requests have been rewritten).

The package has a lot of functionality. Analytics are at the crux of this package but are for a future PR.

[JHawk0224]

This is amazing!

For the status code comments, I don't think they need to be changed, I just wanted to point them out.

On an overall note, I see when logging in that the ProgressView we had inserted over the login sheet is no longer there (action is still disabled though preventing stale web request - ty). Is it possible we can add it back? Ik it's Penn's fault for being slow, but otherwise there's no indication something is happening.

Also, when testing, I just logged in but it brought be to the Login page after a successful login. Then clicking again doesn't do anything, see below video. Not sure why it's happening, but should be fixed.

weird-behavior.mov

Note that I am not done testing, so I will be continuing to add comments, but I thought I would share this review for now.

[JHawk0224]

I'm assuming we don't need to store cookies anymore and LabsPlatform handles everything?

[jonathanmelitski]

actually an incredible catch, forgot that HTTPCookieStorage doesn't persist through restarts, which is what LabsPlatform is currently doing. Yes it is handled by LabsPlatform (albeit evidently not to a full capacity) and will fix. Btw I'm going to PR my changes to LabsPlatformSwift just to add a reference.

[JHawk0224]

What's the difference between this and the AuthManager's clearAccountData?

[jonathanmelitski]

I believe it's copied and pasted. I don't know if it would be incredibly difficult to remove RootViewController from the project. Really just the applicationDidEnterForeground function, moving it to an onChange of scenePhase.

[jonathanmelitski]

This is amazing!

For the status code comments, I don't think they need to be changed, I just wanted to point them out.

On an overall note, I see when logging in that the ProgressView we had inserted over the login sheet is no longer there (action is still disabled though preventing stale web request - ty). Is it possible we can add it back? Ik it's Penn's fault for being slow, but otherwise there's no indication something is happening.

Also, when testing, I just logged in but it brought be to the Login page after a successful login. Then clicking again doesn't do anything, see below video. Not sure why it's happening, but should be fixed.

weird-behavior.mov
Note that I am not done testing, so I will be continuing to add comments, but I thought I would share this review for now.

my thought/initial guess, the client id you're using isn't setup for the auth flow that I've been using. Oversight on my part, and it reminds me that this will need to be fixed prior to deployment.

[JHawk0224]

This is amazing!
For the status code comments, I don't think they need to be changed, I just wanted to point them out.
On an overall note, I see when logging in that the ProgressView we had inserted over the login sheet is no longer there (action is still disabled though preventing stale web request - ty). Is it possible we can add it back? Ik it's Penn's fault for being slow, but otherwise there's no indication something is happening.
Also, when testing, I just logged in but it brought be to the Login page after a successful login. Then clicking again doesn't do anything, see below video. Not sure why it's happening, but should be fixed.
weird-behavior.mov
Note that I am not done testing, so I will be continuing to add comments, but I thought I would share this review for now.

my thought/initial guess, the client id you're using isn't setup for the auth flow that I've been using. Oversight on my part, and it reminds me that this will need to be fixed prior to deployment.

Ok I will test again when I get a chance.

[JHawk0224]

This is amazing!
For the status code comments, I don't think they need to be changed, I just wanted to point them out.
On an overall note, I see when logging in that the ProgressView we had inserted over the login sheet is no longer there (action is still disabled though preventing stale web request - ty). Is it possible we can add it back? Ik it's Penn's fault for being slow, but otherwise there's no indication something is happening.
Also, when testing, I just logged in but it brought be to the Login page after a successful login. Then clicking again doesn't do anything, see below video. Not sure why it's happening, but should be fixed.
weird-behavior.mov
Note that I am not done testing, so I will be continuing to add comments, but I thought I would share this review for now.

my thought/initial guess, the client id you're using isn't setup for the auth flow that I've been using. Oversight on my part, and it reminds me that this will need to be fixed prior to deployment.

Also re adding ProgressView for authentication with penn, it should be really easy. Basically just changing AuthWebView.swift in LabsPlatformSwift to use

ZStack {
    AuthWebViewRepresentable(url: url, redirect: redirect, isLoading: $isLoading, completion: callback)

    if isLoading {
        Color.black.opacity(0.1)
            .ignoresSafeArea()

        ProgressView()
            .tint(nil)
            .scaleEffect(1.6)
            .frame(width: 100, height: 100)
            .background(.thickMaterial)
            .cornerRadius(16)
    }
}

[jonathanmelitski]

See PR in LabsPlatformSwift. Also I sent working clientID via Slack

[jonathanmelitski]

if isLoading {
        Color.black.opacity(0.1)
            .ignoresSafeArea()

        ProgressView()
            .tint(nil)
            .scaleEffect(1.6)
            .frame(width: 100, height: 100)
            .background(.thickMaterial)
            .cornerRadius(16)
    }

This is oddly challenging, there's a SwiftUI safety/optimization where if the webview isn't the foremost view, it disables it updating.