Skip to content

Unfeature Flag Quick Book #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
khoiddinh wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Unfeature Flag Quick Book #677

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
490bdd8
rm quickbook feature flag
khoiddinh Apr 24, 2026
61b28f6
Merge branch 'main' into khoidinh/quickbook-featureflag
jonathanmelitski Apr 24, 2026
a12dbf0
Build a fantastic new UI
jonathanmelitski Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PennMobile/GSR-Booking/Views/Booking/GSRBookingToolbarView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ struct GSRBookingToolbarView: View {
}
}
.transition(.move(edge: .leading).combined(with: .opacity))
} else if FeatureFlags.shared.gsrQuickBook {
} else {
RoomFinderSelectionPanel(vm: vm, isEnabled: $startedQuickBook)
.transition(.move(edge: .leading).combined(with: .opacity))
}
Expand Down
2 changes: 0 additions & 2 deletions PennMobileShared/Feature Flags/FeatureFlags.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ public final class FeatureFlags: @unchecked Sendable {

@FeatureFlagDefinition("ALWAYS_SHOW_FEATURE_FLAG_SETTINGS", channel: .testFlight) public var alwaysShowFeatureFlagSettings
@FeatureFlagDefinition("TEST_FEATURE_FLAG", channel: .adHoc) public var testFeatureFlag

@FeatureFlagDefinition("GSR_QUICK_BOOK", channel: .testFlight) public var gsrQuickBook

@FeatureFlagDefinition("SHOW_AUTH_SETTINGS", channel: .experimental) public var showAuthSettings

Expand Down
Loading