Skip to content

Update Fitness for new API#368

Merged
minghansun1 merged 3 commits into
masterfrom
jon0/fix-fitness
Feb 2, 2026
Merged

Update Fitness for new API#368
minghansun1 merged 3 commits into
masterfrom
jon0/fix-fitness

Conversation

@jonathanmelitski
Copy link
Copy Markdown
Contributor

@jonathanmelitski jonathanmelitski commented Nov 1, 2025

I was bored and decided to see if penn facility usage counts are back up. Not only are they back up, but they have an API that we can scrape now!

@gitguardian
Copy link
Copy Markdown

gitguardian Bot commented Nov 1, 2025

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@jonathanmelitski
Copy link
Copy Markdown
Contributor Author

jonathanmelitski commented Nov 2, 2025

GitGuardian alert marked as a false positive.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 2, 2025

Codecov Report

❌ Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.82%. Comparing base (6453435) to head (93cb464).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...nndata/management/commands/get_fitness_snapshot.py 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #368      +/-   ##
==========================================
- Coverage   88.85%   88.82%   -0.03%     
==========================================
  Files          73       73              
  Lines        3184     3177       -7     
==========================================
- Hits         2829     2822       -7     
  Misses        355      355              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@@ -12,77 +13,60 @@ def cap_string(s):


def get_usages():

# count/capacities default to 0 since spreadsheet number appears blank if no one there
locations = [
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to keep this as a sanity check? I'm assuming that because Penn rec is using a formal API now, we will always include all locations, but I defer.

)
"https://goboardapi.azurewebsites.net/api/",
"FacilityCount/GetCountsByAccount?",
"AccountAPIKey=05b8a871-ae40-4bda-8f20-ad5a426e7f8b",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitGuardian didn't like this, and will probably continue to flag it in the future. Should we put it in Sentry just for sake of not having to deal with this?

@@ -0,0 +1,236 @@
[
{
"LocationId": 10183,
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This location is not necessary, and is filtered out of the data.

@jonathanmelitski jonathanmelitski marked this pull request as ready for review November 2, 2025 17:14
@jonathanmelitski
Copy link
Copy Markdown
Contributor Author

@dr-Jess updated url links to directly reflect location names.

@minghansun1 minghansun1 merged commit fac021e into master Feb 2, 2026
5 of 6 checks passed
@minghansun1 minghansun1 deleted the jon0/fix-fitness branch February 2, 2026 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants