Update Fitness for new API#368
Conversation
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
|
GitGuardian alert marked as a false positive. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #368 +/- ##
==========================================
- Coverage 88.85% 88.82% -0.03%
==========================================
Files 73 73
Lines 3184 3177 -7
==========================================
- Hits 2829 2822 -7
Misses 355 355 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -12,77 +13,60 @@ def cap_string(s): | |||
|
|
|||
|
|
|||
| def get_usages(): | |||
|
|
|||
| # count/capacities default to 0 since spreadsheet number appears blank if no one there | |||
| locations = [ | |||
There was a problem hiding this comment.
Do we want to keep this as a sanity check? I'm assuming that because Penn rec is using a formal API now, we will always include all locations, but I defer.
| ) | ||
| "https://goboardapi.azurewebsites.net/api/", | ||
| "FacilityCount/GetCountsByAccount?", | ||
| "AccountAPIKey=05b8a871-ae40-4bda-8f20-ad5a426e7f8b", |
There was a problem hiding this comment.
GitGuardian didn't like this, and will probably continue to flag it in the future. Should we put it in Sentry just for sake of not having to deal with this?
| @@ -0,0 +1,236 @@ | |||
| [ | |||
| { | |||
| "LocationId": 10183, | |||
There was a problem hiding this comment.
This location is not necessary, and is filtered out of the data.
85699cb to
a237ab0
Compare
a237ab0 to
3dfe7e3
Compare
|
@dr-Jess updated url links to directly reflect location names. |
I was bored and decided to see if penn facility usage counts are back up. Not only are they back up, but they have an API that we can scrape now!