Skip to content

Update GSR share code lookup and add owner name display#375

Merged
dr-Jess merged 1 commit into
masterfrom
shared-gsr-updates
Jan 28, 2026
Merged

Update GSR share code lookup and add owner name display#375
dr-Jess merged 1 commit into
masterfrom
shared-gsr-updates

Conversation

@aangelinali
Copy link
Copy Markdown
Contributor

Summary of Changes

  • Updated GSRShareCodeSerializer.booking_id to correctly lookup bookings by external booking ID instead of internal primary key
  • Added owner_name field so we can access GSR booking owner name (falls back to student PennKey)

@aangelinali aangelinali marked this pull request as draft December 10, 2025 18:02
@aangelinali aangelinali requested a review from dr-Jess December 10, 2025 18:15
@khoiddinh khoiddinh marked this pull request as ready for review December 16, 2025 18:34
Copy link
Copy Markdown
Contributor

@dr-Jess dr-Jess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dr-Jess dr-Jess merged commit 566de03 into master Jan 28, 2026
8 checks passed
@dr-Jess dr-Jess deleted the shared-gsr-updates branch January 28, 2026 17:55
# First creation
response1 = self.client.post("/api/gsr/share/", {"booking_id": self.booking.id})
response1 = self.client.post("/api/gsr/share/", {"booking_id": self.booking.booking_id})
self.assertEqual(response1.status_code, 201)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khoiddinh ensure that you're checking for status code 201 instead of 200.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants