Skip to content

Grace/menu fix#409

Merged
gracech1 merged 7 commits into
masterfrom
grace/menu-fix
Mar 22, 2026
Merged

Grace/menu fix#409
gracech1 merged 7 commits into
masterfrom
grace/menu-fix

Conversation

@gracech1
Copy link
Copy Markdown
Contributor

this pr fails test cases

@minghansun1
Copy link
Copy Markdown
Contributor

I think if you change line 41 in test_views to raise APIError it'll work. IDK how this didn't break anything before tho, cuz it shouldn't be related to the code you pushed.

@gracech1
Copy link
Copy Markdown
Contributor Author

Minghan I think the checks pass now

Copy link
Copy Markdown
Contributor

@minghansun1 minghansun1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@minghansun1 minghansun1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gracech1 gracech1 merged commit bea49b7 into master Mar 22, 2026
8 checks passed
@gracech1 gracech1 deleted the grace/menu-fix branch March 22, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants