Skip to content

Add feature branch deploy#142

Draft
joyliu-q wants to merge 38 commits into
masterfrom
feat/add-feature-branch-deploy
Draft

Add feature branch deploy#142
joyliu-q wants to merge 38 commits into
masterfrom
feat/add-feature-branch-deploy

Conversation

@joyliu-q
Copy link
Copy Markdown
Contributor

@joyliu-q joyliu-q commented Jun 20, 2022

Doing it on a super simple react app to test it out.

TODO

  • Add branch protection rule against feat/ so randoms can't open a feature branch and deploy vulnerable code.
  • Design TODO: figure out good alternative to adding a message that says "Successfully deployed feature branch!" - Considerations thread
  • Test PR merge
  • Test PR close

Demo: https://pr-142.pennlabs.org/

@joyliu-q joyliu-q changed the title Add feature branch deploy (hopefully it works lol) Add feature branch deploy Jun 20, 2022
@joyliu-q joyliu-q marked this pull request as draft June 20, 2022 19:03
@github-actions
Copy link
Copy Markdown

Successfully deployed feature branch!

@github-actions
Copy link
Copy Markdown

Successfully deployed feature branch!

@joyliu-q
Copy link
Copy Markdown
Contributor Author

joyliu-q commented Jun 28, 2022

Oh wait, it should probably not say "Successfully deployed feature branch" every single time you add changes. That might get spammy on large feature branches that get pushed a bunch of small commits.

Considerations thread: pennlabs/infrastructure#98 (comment)

@github-actions
Copy link
Copy Markdown

Successfully deployed feature branch!

@github-actions
Copy link
Copy Markdown

Successfully deployed feature branch to:
pr-142-pennlabs.org

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 28, 2022

Deployment preview for commit 8880982aa53727b3ac9e876d1416f2421499df74 ready at:
pr-142.pennlabs.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant