Skip to content

Aug#194

Open
yuntongf wants to merge 4 commits into
masterfrom
aug
Open

Aug#194
yuntongf wants to merge 4 commits into
masterfrom
aug

Conversation

@yuntongf
Copy link
Copy Markdown

No description provided.

Comment thread .yarnrc.yml
@@ -0,0 +1 @@
nodeLinker: node-modules
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HmMmmMMmM

Comment thread src/json/members/august.json Outdated
"alumnus": false,
"graduation_year": 2025,
"job": null
} No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: new line

Comment thread src/json/members/august.json Outdated
"hometown": "Tianjin China",
"team": "Penn Courses",
"roles": ["Frontend Engineer"],
"photo": "https://media.licdn.com/dms/image/D4E03AQHKm_uMFR55Zw/profile-displayphoto-shrink_800_800/0/1686604042664?e=1701302400&v=beta&t=0S1WNZkHfjgYDwf2ky2BBLLgFI0tqx0ww1Jkptk0h2Y",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's easy for this type of photo to no longer have a valid URL after a certain period of time. Rather than right clicking on LinkedIn profile to copy image URL, I would recommend using a hosting site like Imgur.

Comment thread src/json/members/august.json Outdated
"major": "Computer Science",
"school": "Engineering",
"bio": "Salt air, and the rust on your door\n I never needed anything more\n Whispers of \"Are you sure?\" \nNever have I ever before\"",
"hometown": "Tianjin China",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nit, maybe add a ,.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants