Skip to content

Migrate to shared-actions #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vsingh18567 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Migrate to shared-actions #223

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc2c23b
nuke cdk, update workflows to use shared action
vsingh18567 Oct 5, 2023
df076e6
address changes
vsingh18567 Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/cdk/.gitignore
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions .github/cdk/cdkactions.yaml
View file
Open in desktop

This file was deleted.

25 changes: 0 additions & 25 deletions .github/cdk/main.ts
View file
Open in desktop

This file was deleted.

25 changes: 0 additions & 25 deletions .github/cdk/package.json
View file
Open in desktop

This file was deleted.

33 changes: 0 additions & 33 deletions .github/cdk/tsconfig.json
View file
Open in desktop

This file was deleted.

216 changes: 0 additions & 216 deletions .github/cdk/yarn.lock
View file
Open in desktop

This file was deleted.

24 changes: 24 additions & 0 deletions .github/workflows/build-and-deploy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# Generated by cdkactions. Do not modify
Copy link
Copy Markdown
Contributor

@joyliu-q joyliu-q Oct 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's delete these two top lines and sub in:

# ========================================
# Note:  If you make changes to this CI/CD, please include someone from DevOps in the list of reviewers for the PR.
# ========================================

Copy link
Copy Markdown
Contributor Author

@vsingh18567 vsingh18567 Oct 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed

# Generated as part of the 'website' stack.
name: Build and Deploy
on: push
jobs:
react-check-and-publish:
name: React Check & Publish Frontend
runs-on: ubuntu-latest
steps:
- uses: pennlabs/shared-actions/.github/workflows/react.yaml@main
Copy link
Copy Markdown
Contributor

@joyliu-q joyliu-q Oct 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than pinning to main, let's do a specific version or hash (see penn-clubs example)

I just released the new changes you made to shared-actions, so we can start using v0.1.2

Copy link
Copy Markdown
Contributor Author

@vsingh18567 vsingh18567 Oct 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed

with:
imageName: website
githubRef: ${{ github.ref }}
gitSha: ${{ github.sha }}
deploy:
runs-on: ubuntu-latest
if: github.ref == 'refs/heads/master'
steps:
- uses: pennlabs/shared-actions/.github/workflows/deployment.yaml@main
with:
githubRef: ${{ github.ref }}
gitSha: ${{ github.sha }}
needs:
- react-check-and-publish
Loading