[BACKLOG-43593] Evaluate Grandparent POM Approach and Build Proof of Concept#824
Open
eddie-martinez wants to merge 1 commit into
Open
[BACKLOG-43593] Evaluate Grandparent POM Approach and Build Proof of Concept#824eddie-martinez wants to merge 1 commit into
eddie-martinez wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new CE grandparent POM to hold shared Maven build configuration (plugins/profiles), and updates the existing parent POM structure to inherit from it as a proof-of-concept “grandparent” approach.
Changes:
- Added a new
pentaho-ce-grandparent-pommodule containing shared build/plugin/profile configuration. - Updated the root
pentaho-parent-pomto inherit frompentaho-ce-grandparent-pomand include it as a module. - Moved build/profiles configuration out of the root POM into the new grandparent POM (root POM now keeps dependency/version management and repo/distribution config).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
pom.xml |
Makes pentaho-parent-pom inherit from the new grandparent and adds it as a module; removes build/profiles from this POM. |
pentaho-ce-grandparent-pom/pom.xml |
New grandparent POM that centralizes shared build/plugin management and Maven profiles. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
eddie-martinez
force-pushed
the
BACKLOG-43593
branch
from
c1f6c7c to
12e0759
Compare
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
No data about coverage
Collaborator
|
Note:Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system. |
Collaborator
✅ Build finished in 1m 46sBuild command: mvn clean verify -B -e -Daudit -Djs.no.sandbox❗ No tests found!ℹ️ This is an automatic message |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.