fix[PDI-20435]: Refactor shell scripts for improved variable handling and quoting

[befc]

This pull request standardizes environment variable assignment and quoting across Windows batch (.bat) and Unix shell (.sh) scripts for Kitchen, Pan, Spoon, and Translator utilities. The changes improve reliability and prevent issues with spaces or special characters in paths and arguments. Most modifications replace legacy variable assignment with the recommended syntax and add consistent quoting to directory and file references.

Variable assignment and quoting standardization:

• Updated all Windows batch scripts (Spoon.bat, Kitchen.bat, Pan.bat, Translator.bat, set-pentaho-env.bat) to use SET "VAR=value" syntax for environment variables, ensuring proper handling of values with spaces. Also, arguments and paths are now consistently quoted when referenced. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]
• Updated Unix shell scripts (spoon.sh, kitchen.sh, pan.sh, set-pentaho-env.sh) to consistently quote variable assignments and path references, such as LD_LIBRARY_PATH, MOZILLA_FIVE_HOME, and LIBPATH. This prevents issues when directories contain spaces or special characters. [1] [2] [3] [4] [5] [6]

Path handling and argument quoting improvements:

• All script invocations now quote arguments and directory paths, such as when changing directories or passing arguments to Java processes, to ensure correct behavior regardless of directory names or user input. [1] [2] [3] [4] [5] [6] [7]

These changes make the scripts more robust and portable, reducing the risk of runtime errors due to improper variable handling or quoting.

[hitachivantarasonarqube]

Quality Gate passed

Issues

• 0 New Issues
• 0 Fixed Issues
• 0 Accepted Issues

Measures

• 0 Security Hotspots
• No data about coverage (25.30% Estimated after merge)
• No data about duplications (17.10% Estimated after merge)

Project ID: org.pentaho.di:pdi

View in SonarQube

[buildguy]

Note:

---

Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.

---

🐸 JFrog Frogbot

[buildguy]

⚠️ Build finished in 43m 44s

Build command:

mvn clean verify -B -e -Daudit -Djs.no.sandbox

---

⛔ Failed Tests

⛈️ 2 test(s) failed:

org.pentaho.di.repository.pur.PurRepositoryStressTest.runLoadTest (click to expand)

${result.errorDetails}

org.pentaho.ui.database.event.FragmentHandlerTest.org.pentaho.ui.database.event.FragmentHandlerTest (click to expand)

'void org.eclipse.swt.internal.gtk.OS._cachejvmptr()'

Tests run: 6314, Failures: 2, Skipped: 25    Test Results

---

ℹ️ This is an automatic message