[PDI-20318] Change use of Messages from reporting to PDI's BaseMessages #9973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Analysis Details0 Issues
Coverage and Duplications
Project ID: org.pentaho.di:pdi |
Collaborator
|
Note:Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system. |
Collaborator
✅ Build finished in 25m 43sBuild command: mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl \
plugins/pentaho-reporting/impl👌 All tests passed! Tests run: 11, Failures: 0, Skipped: 0 Test Results ℹ️ This is an automatic message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the "Messages" class fails to load the bundle for translation, it causes an error - that was caught, but it forces the default Locale to US. Customers. On the other hand, BaseMessages is what should be used generally with PDI, and it will gracefully "translate" or notify if it doesn't have a translation. No need to change the Locale used for generating reports.
Also - this is required as part of another effort, which will be logged soon.