Take the test count out of the narration, so that line cannot go stale - #60
Merged
Merged
Conversation
The rebuilt frame reads 556 because scene_kit.test_count() takes it off the
README. The voice beside it said "doscientos setenta" / "two hundred and
seventy", because a recorded take has nothing keeping it honest -- and the two
were about to contradict each other on screen.
The number is gone from the line rather than corrected to 556. Correcting it
buys a stronger sentence that is wrong again at the next release and needs a
re-record every time the suite grows; dropping it costs one re-record, ever.
The count is still on screen, read from the one place that has a test enforcing
it. This is test_count()'s own argument applied to the audio.
es "...no hace falta licencia, y sus tests corren gratis en un runner publico."
en "...it needs no licence, and its tests run free on a public runner."
Both takes re-recorded with the voices the guion already names -- Marcela for
Spanish, Rachel for English, who is not in the account and was already pinned by
id in PREMADE_VOICE_IDS for exactly this reason. The key was passed through the
environment for the run; nothing was written into this repository.
The line is shorter without the number, so the scene is too: 17.8s becomes 17.0s
in Spanish and 16.4s in English. --retime read that off the new takes, every
other scene came back at the length it already had, and the six chapter stamps
after 08-roslyn in PUBLICACION.md move with it. Films are now 3:46 and 3:28.
Not touched, because it is a different kind of claim: the blog article says
"270 tests" in four files (es/en, md/html). A film is regenerated from live
sources, so a stale number in it is a defect. An article is a dated publication,
and what it said when it was published is not false. Worth deciding, not worth
deciding silently.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W45tzJFX3NoSrk7svtQeKT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #59, which rebuilt the film and left this open because it needed a decision and a recording, not a rebuild.
The screen fixed itself; the voice could not
scene_kit.test_count()reads the suite size off the README instead of having it typed into a slide, so the rebuild moved08-roslynfrom 295 to 556 on its own. Its docstring is the whole argument:A recorded take has nothing keeping it honest. The narration said "doscientos setenta" / "two hundred and seventy" — so the rebuilt film was about to contradict itself out loud, in the very scene about not stating things you cannot back.
The number is gone from the line, not corrected to 556
Correcting it buys a stronger sentence that is wrong again at the next release and needs a re-record every time the suite grows. Dropping it costs one re-record, ever — and the count stays on screen, read from the one place that has a test enforcing it. This is
test_count()'s own argument applied to the audio.Re-recorded with the voices the guion already names: Marcela for Spanish, and Rachel for English — who is not in the account and was already pinned by id in
PREMADE_VOICE_IDS, with a comment saying why. Both resolved without touching the resolver.No credential entered this repository.
--narratereadsELEVENLABS_API_KEY, so the key was passed through the environment for the one run; the diff carries nothing secret, anddocs/Blog/video/.elevenlabs.keystill does not exist.--narratealso skips any take that already exists, so this billed for two short lines rather than twenty-two.What moved with it
The line is shorter without the number, so the scene is:
es/08-roslynen/08-roslyn--retimeread those off the new takes and every other scene came back at the length it already had — so the only chapter stamps that move inPUBLICACION.mdare the six after08-roslyn, and they move by a second or two. Both films reassembled and re-probed: 226.6s and 208.1s, h264 + aac, 11/12 scenes voiced as before.One thing left for you, deliberately
The blog article says "270 tests" in four files —
xaflogic-hidden-behaviour-story.{es,en}.{md,html}.I did not touch it, because it is a different kind of claim. A film is regenerated from live sources, so a stale number in it is a defect. An article is a dated publication, and what it said when it was published is not false. Updating it to 556, rephrasing it the way this narration just went, or leaving it as a snapshot are all defensible — which is why it is a decision rather than a fix.
🤖 Generated with Claude Code
https://claude.ai/code/session_01W45tzJFX3NoSrk7svtQeKT