Merged
Conversation
…#2555) ## Description Similarly to MySQL and Postgres, we are adding `connectionParams` field to the SingleStore config. ## PR Checklist > Thank you for opening a Pull Request! Before submitting your PR, there are a > few things you can do to make sure it goes smoothly: - [x] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md) - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) - [x] Make sure to add `!` if this involve a breaking change 🛠️ Fixes #<issue_number_goes_here> Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com>
## Summary Adds MCP tool annotations (`readOnlyHint`, `destructiveHint`) to all remaining tools (excluding Looker and MongoDB which already have annotations from #2219). ## Changes - Added `Annotations *tools.ToolAnnotations` field to Config structs for YAML configuration override - Added `readOnlyHint: true` to 92 read-only tools (queries, fetches, lists, gets, searches) - Added `destructiveHint: true` to 50 tools that modify data (execute SQL, create, delete, update) - Used `GetAnnotationsOrDefault` pattern for user-overridable defaults - Applied to 156 tool files across all database and service tools ## Why This Matters Tool annotations provide semantic metadata that helps MCP clients: - Auto-approve safe (read-only) operations without user confirmation - Show appropriate warnings for destructive operations - Cache results of read-only tools more aggressively ## Classification Approach - **Read-only**: Tools that only query/fetch data (list, get, search, schema, stats) - **Destructive**: Tools that can modify data (execute SQL, create, update, delete) - General SQL execution tools marked destructive (can run arbitrary DML) - Wait/poll and compile/validate tools are read-only ## Testing - [x] `go build ./...` passes - [x] `go test ./internal/tools/...` - all tests pass - [x] `golangci-lint run --fix` - 0 issues - [x] Annotation values match actual tool behavior ## CLA Fix This push resolves the CLA check failure. Commit now authored with correct GitHub noreply email. Co-authored-by: bryankthompson <199543909+bryankthompson@users.noreply.github.com> Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )