Open
Conversation
cjfreeze
reviewed
Jan 31, 2022
Contributor
cjfreeze
left a comment
cjfreeze
left a comment
There was a problem hiding this comment.
Love the addition, just a quick comment. If it's not too much trouble could you also write a quick doc for the select function
cjfreeze
reviewed
Feb 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to be able to present a list of options for someone to select in the chore runner ui. This adds that. I also wanted the ability to write log messages with raw html so i could embed a link for the user to click on a chore completion.