Skip to content

SEP-1841: Correct sidecar README guidance on when to set SEP_INTERNAL_TOKEN #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yyyyyyyan merged 3 commits into from
Aug 19, 2026
Merged

SEP-1841: Correct sidecar README guidance on when to set SEP_INTERNAL_TOKEN #1372

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2670de8
Initial plan
Copilot Aug 19, 2026
6779caf
SEP-1841: replace stale nginx-overlay guidance with rotation reason i…
Copilot Aug 19, 2026
418d479
Merge branch 'main' into copilot/sep-1841-update-readme-guidance
yyyyyyyan Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sidecar/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ Already canonical, so they are passed straight through with no expansion:

| Input | Required | Notes |
|---|---|---|
| `SEP_INTERNAL_TOKEN` | no | Derived from `SECRET_KEY` by HMAC when unset. Set it explicitly when PMM's nginx overlay pins a specific value. |
| `SEP_INTERNAL_TOKEN` | no | Authenticates SEP-internal service-to-service calls, such as the scheduled inventory sync. Derived from `SECRET_KEY` by HMAC when unset, so every process sharing the key resolves the same token. Set it explicitly only to rotate it independently of `SECRET_KEY`. |
| `BASE_URL` | no* | The side-car's address as reachable from Nomad task executors, including SEP's URL prefix — `https://pmm-server:8443/sep`, not `https://pmm-server:8443`. Download URLs are joined onto its path rather than replacing it, so a value omitting the prefix yields a well-formed URL that no longer routes to SEP; startup warns when it does. *Required when tasks download scripts or artifacts. |

Any canonical variable can also be set directly — an explicit
Expand Down
Loading