Conversation
peter-o-addo
marked this pull request as ready for review
September 3, 2026 08:00
peter-o-addo
requested review from
marcuscruz-percona and
yyyyyyyan
as code owners
September 3, 2026 08:00
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The normalization unintentionally removes URL base-path coverage from the parity assertions.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Prevents signed-URL test flakes by comparing decoded token payloads instead of timestamp-sensitive URLs.
Changes:
- Adds signed-token decoding helpers.
- Updates two execution-metadata equality assertions.
File summaries
| File | Description |
|---|---|
tests/app/sep/snippets/test_script_source.py |
Normalizes signed URLs in metadata comparisons. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 3
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new helpers need complete docstrings and should avoid duplicating the artifact route literal.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
Suppressed comments (1)
tests/app/sep/snippets/test_script_source.py:107
- This new helper's docstring does not document its
metaparameter or returned dump, leaving the helper contract incomplete. Expand it with the corresponding rST fields.
def _meta_dump_decoded(meta: SnippetExecutionMeta) -> dict[str, object]:
"""Return ``meta.model_dump()`` with ``snippet_source`` timestamp-normalized."""
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Balanced
yyyyyyyan
approved these changes
Sep 3, 2026
yyyyyyyan
enabled auto-merge (squash)
September 3, 2026 16:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Compare decoded itsdangerous payloads instead of raw signed URLs in snippet execution-meta equality checks so tests no longer flake across a second boundary.
tests/app/sep/snippets/test_script_source.py: decodesnippet_sourcebefore comparing metas in the legacy-path and extra-args alias testsTested
Skip test
Checklist
make test)make run-pre-commit)make makemigrations)changelog.d/if the change is user-facing (make changelog-add), or confirmed N/A (internal-only change, or a same-release-cycle fix for an unreleased sibling ticket)