Skip to content

EVEREST-1918 | check for dupicate IP and netmask entries for external access #1204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: EVEREST-1909-prevent-duplicate-ip
Choose a base branch
from
Open

EVEREST-1918 | check for dupicate IP and netmask entries for external access #1204

wants to merge 13 commits into from

Conversation

Tikdev00
Copy link
Collaborator

@Tikdev00 Tikdev00 commented Mar 13, 2025 •
edited by jira bot
Loading

EVEREST-1918 Powered by Pull Request Badge

@Tikdev00 Tikdev00 self-assigned this Mar 13, 2025
@Tikdev00 Tikdev00 requested a review from a team as a code owner March 13, 2025 15:57
@Tikdev00 Tikdev00 changed the title EVEREST-1918 | check for dupicate IP and netmask entries for external… EVEREST-1918 | check for dupicate IP and netmask entries for external access Mar 13, 2025
@Tikdev00
Copy link
Collaborator Author

@fabio-silva should I point target branch as 1909 which is base for this, or keep main?

@fabio-silva
Copy link
Collaborator

@fabio-silva should I point target branch as 1909 which is base for this, or keep main?

@Tikdev00 1909, please

@Tikdev00 Tikdev00 changed the base branch from main to EVEREST-1909-prevent-duplicate-ip March 14, 2025 09:54
@Tikdev00 Tikdev00 requested a review from fabio-silva March 17, 2025 15:13
fabio-silva
fabio-silva requested changes Mar 17, 2025
View reviewed changes
Copy link
Collaborator

@fabio-silva fabio-silva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tikdev00 Please check the comment.
Also, let's add a unit test to make sure we get an error when we type duplicate entries, with and without netmask

@fabio-silva fabio-silva requested a review from a team March 17, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabio-silva fabio-silva fabio-silva approved these changes

@dianabirs dianabirs dianabirs approved these changes

Assignees

@Tikdev00 Tikdev00

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tikdev00 @fabio-silva @dianabirs