EVEREST-1838 | disable PITR after no schedules or backups are left

ui/apps/everest/src/pages/db-cluster-details/backups/backups-list/backups-list.messages.tsx

@@ -4,7 +4,11 @@ import { PG_SLOTS_LIMIT } from 'consts';
 export const Messages = {
   deleteDialog: {
     header: 'Delete backup',
-    content: (backupName: string, dbType: DbEngineType) => (
+    content: (
+      backupName: string,
+      dbType: DbEngineType,
+      willDisablePITR: boolean
+    ) => (
       <>
         {dbType === DbEngineType.POSTGRESQL ? (
           <>
@@ -17,6 +21,8 @@ export const Messages = {
             backup?
           </>
         )}
+        {willDisablePITR &&
+          ' This will disable point-in-time recovery, as it requires a full backup.'}
       </>
     ),
     alertMessage:
@@ -45,4 +51,6 @@ export const Messages = {
   restoreToNewDb: 'Create new DB',
   pgMaximum: (slotsInUse: number) =>
     `Note: There is a maximum of 3 backup schedules for PostgreSQL. You are using ${slotsInUse} out of ${PG_SLOTS_LIMIT} available storages.`,
+  pitrToBeDisabled:
+    'This will disable point-in-time recovery, as it requires a full backup.',
 };

ui/apps/everest/src/pages/db-cluster-details/backups/backups-list/backups-list.tsx

@@ -23,12 +23,17 @@ import {
   useDbBackups,
   useDbClusterPitr,
   useDeleteBackup,
-} from 'hooks/api/backups/useBackups';
+  useUpdateDbClusterWithConflictRetry,
+} from 'hooks';
 import { MRT_ColumnDef } from 'material-react-table';
 import { Alert, Typography } from '@mui/material';
 import { RestoreDbModal } from 'modals/index.ts';
 import { useContext, useMemo, useState } from 'react';
-import { Backup, BackupStatus } from 'shared-types/backups.types';
+import {
+  Backup,
+  BackupStatus,
+  GetBackupsPayload,
+} from 'shared-types/backups.types';
 import { ScheduleModalContext } from '../backups.context.ts';
 import { BACKUP_STATUS_TO_BASE_STATUS } from './backups-list.constants';
 import { Messages } from './backups-list.messages';
@@ -57,16 +62,19 @@ export const BackupsList = () => {
     setOpenOnDemandModal,
   } = useContext(ScheduleModalContext);
 
-  const { mutate: deleteBackup, isPending: deletingBackup } = useDeleteBackup(
-    dbCluster?.metadata.namespace
-  );
   const { data: backups = [] } = useDbBackups(
     dbCluster.metadata.name,
     dbCluster.metadata.namespace,
     {
       refetchInterval: 10 * 1000,
     }
   );
+  const { mutate: updateCluster } = useUpdateDbClusterWithConflictRetry(
+    dbCluster,
+    {
+      onSuccess: () => handleCloseDeleteDialog(),
+    }
+  );
   const { data: pitrData } = useDbClusterPitr(
     dbCluster.metadata.name!,
     dbCluster.metadata.namespace,
@@ -78,6 +86,16 @@ export const BackupsList = () => {
     dbCluster?.metadata.namespace
   );
   const dbType = dbCluster.spec?.engine.type;
+  const pitrEnabled = !!dbCluster.spec?.backup?.pitr?.enabled;
+  const willDisablePITR =
+    (dbCluster.spec?.backup?.schedules || []).length === 0 &&
+    pitrEnabled &&
+    backups.length === 1;
+
+  const { mutate: deleteBackup, isPending: deletingBackup } = useDeleteBackup(
+    dbCluster?.metadata.namespace
+  );
+
   const { storagesToShow, uniqueStoragesInUse } =
     getAvailableBackupStoragesForBackups(
       backups,
@@ -168,13 +186,42 @@ export const BackupsList = () => {
       { backupName: backupName, cleanupBackupStorage: cleanupBackupStorage },
       {
         onSuccess: () => {
-          queryClient.invalidateQueries({
-            queryKey: [
+          if (willDisablePITR) {
+            updateCluster({
+              ...dbCluster,
+              spec: {
+                ...dbCluster.spec,
+                backup: {
+                  ...dbCluster.spec.backup,
+                  pitr: {
+                    enabled: false,
+                    backupStorageName:
+                      dbCluster.spec.backup?.pitr?.backupStorageName || '',
+                  },
+                },
+              },
+            });
+          }
+          queryClient.setQueryData(
+            [
               BACKUPS_QUERY_KEY,
               dbCluster.metadata.namespace,
               dbCluster.metadata.name,
             ],
-          });
+            (oldData: GetBackupsPayload) => ({
+              items: oldData.items.map((backup) =>
+                backup.metadata.name === backupName
+                  ? {
+                      ...backup,
+                      status: {
+                        ...backup.status,
+                        state: BackupStatus.DELETING,
+                      },
+                    }
+                  : backup
+              ),
+            })
+          );
           handleCloseDeleteDialog();
         },
       }
@@ -222,6 +269,7 @@ export const BackupsList = () => {
             onNowClick={handleManualBackup}
             onScheduleClick={handleScheduledBackup}
             noStoragesAvailable={noStoragesAvailable}
+            backups={backups}
           />
         )}
         enableRowActions
@@ -253,7 +301,8 @@ export const BackupsList = () => {
           confirmationInput={false}
           dialogContent={Messages.deleteDialog.content(
             selectedBackup,
-            dbCluster.spec.engine.type
+            dbCluster.spec.engine.type,
+            willDisablePITR
           )}
           alertMessage={Messages.deleteDialog.alertMessage}
           submitMessage={Messages.deleteDialog.confirmButton}

ui/apps/everest/src/pages/db-cluster-details/backups/backups-list/table-header/backups-list-table-header.messages.tsx

@@ -3,10 +3,12 @@ export const Messages = {
   schedule: 'Schedule',
   deleteModal: {
     header: 'Delete schedule',
-    content: (scheduleName: string) => (
+    content: (scheduleName: string, willDisablePITR: boolean) => (
       <>
         Are you sure you want to permanently delete schedule{' '}
-        <b>{scheduleName}</b>?
+        <b>{scheduleName}</b>?{' '}
+        {willDisablePITR &&
+          ' This will disable point-in-time recovery, as it requires a full backup.'}
       </>
     ),
   },

ui/apps/everest/src/pages/db-cluster-details/backups/backups-list/table-header/backups-list-table-header.tsx

@@ -10,11 +10,13 @@ import ScheduledBackupsList from './scheduled-backups-list';
 import { BackupListTableHeaderProps } from './backups-list-table-header.types';
 import { Messages } from './backups-list-table-header.messages';
 import { useRBACPermissions } from 'hooks/rbac';
+import { BackupStatus } from 'shared-types/backups.types';
 
 const BackupListTableHeader = ({
   onNowClick,
   onScheduleClick,
   noStoragesAvailable,
+  backups,
 }: BackupListTableHeaderProps) => {
   const [showSchedules, setShowSchedules] = useState(false);
   const { dbCluster } = useContext(ScheduleModalContext);
@@ -142,7 +144,14 @@ const BackupListTableHeader = ({
           </MenuButton>
         )}
       </Box>
-      {schedulesNumber > 0 && showSchedules && <ScheduledBackupsList />}
+      {schedulesNumber > 0 && showSchedules && (
+        <ScheduledBackupsList
+          emptyBackups={
+            backups.length === 0 ||
+            backups.every((b) => b.state === BackupStatus.DELETING)
+          }
+        />
+      )}
     </>
   );
 };

ui/apps/everest/src/pages/db-cluster-details/backups/backups-list/table-header/backups-list-table-header.types.ts

@@ -1,5 +1,8 @@
+import { Backup } from 'shared-types/backups.types';
+
 export type BackupListTableHeaderProps = {
   onNowClick: () => void;
   onScheduleClick: () => void;
   noStoragesAvailable?: boolean;
+  backups: Backup[];
 };

ui/apps/everest/src/pages/db-cluster-details/backups/backups-list/table-header/scheduled-backups-list.tsx

@@ -16,7 +16,11 @@ import {
 import { useUpdateDbClusterWithConflictRetry } from 'hooks';
 import { WizardMode } from 'shared-types/wizard.types';
 
-const ScheduledBackupsList = () => {
+type Props = {
+  emptyBackups: boolean;
+};
+
+const ScheduledBackupsList = ({ emptyBackups }: Props) => {
   const [openDeleteDialog, setOpenDeleteDialog] = useState(false);
   const [selectedSchedule, setSelectedSchedule] = useState<string>('');
   const {
@@ -30,7 +34,8 @@ const ScheduledBackupsList = () => {
       onSuccess: () => handleCloseDeleteDialog(),
     });
   const [schedules, setSchedules] = useState<ManageableSchedules[]>([]);
-
+  const pitrEnabled = !!dbCluster.spec?.backup?.pitr?.enabled;
+  const willDisablePITR = emptyBackups && schedules.length === 1 && pitrEnabled;
   const handleDelete = (scheduleName: string) => {
     setSelectedSchedule(scheduleName);
     setOpenDeleteDialog(true);
@@ -41,7 +46,9 @@ const ScheduledBackupsList = () => {
   };
 
   const handleConfirmDelete = (scheduleName: string) => {
-    updateCluster(deleteScheduleFromDbCluster(scheduleName, dbCluster));
+    updateCluster(
+      deleteScheduleFromDbCluster(scheduleName, dbCluster, willDisablePITR)
+    );
   };
 
   const handleEdit = (scheduleName: string) => {
@@ -157,7 +164,7 @@ const ScheduledBackupsList = () => {
           handleConfirm={handleConfirmDelete}
           disabledButtons={updatingCluster}
         >
-          {Messages.deleteModal.content(selectedSchedule)}
+          {Messages.deleteModal.content(selectedSchedule, willDisablePITR)}
         </ConfirmDialog>
       )}
     </Stack>

ui/apps/everest/src/utils/db.tsx

@@ -249,7 +249,8 @@ export const changeDbClusterPITR = (
 
 export const deleteScheduleFromDbCluster = (
   scheduleName: string,
-  dbCluster: DbCluster
+  dbCluster: DbCluster,
+  disablePITR: boolean
 ): DbCluster => {
   const schedules = dbCluster?.spec?.backup?.schedules || [];
   const filteredSchedulesWithCronCorrection = schedules.reduce(
@@ -270,6 +271,14 @@ export const deleteScheduleFromDbCluster = (
       ...dbCluster?.spec,
       backup: {
         ...dbCluster.spec.backup,
+        ...(disablePITR && {
+          pitr: {
+            ...dbCluster.spec.backup?.pitr,
+            backupStorageName:
+              dbCluster.spec.backup?.pitr?.backupStorageName || '',
+            enabled: false,
+          },
+        }),
         schedules:
           filteredSchedulesWithCronCorrection.length > 0
             ? filteredSchedulesWithCronCorrection