Everest-1931 Improve diagram view #1262
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tikdev00
changed the base branch from
main
to
EVEREST-1862-topology-diagram-view
dianabirs
reviewed
Mar 28, 2025
| button : { | ||
| resetView: 'Reset View', | ||
| } | ||
| } |
There was a problem hiding this comment.
please add new line for end of file
dianabirs
reviewed
Mar 28, 2025
|
|
||
| for (const key of keys) { | ||
| if ( | ||
| typeof component[key] === 'string' |
There was a problem hiding this comment.
why do we need this type check here?
There was a problem hiding this comment.
@dianabirs Because DBClusterComponent can have keys with other types than string and if so we can't call toLowerCase for other types, there are like container array or number and etc. that's why we need to make sure that one is a string
dianabirs
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screencast.from.2025-03-27.19-43-49.webm