Skip to content

EVEREST-1958 | fix resources accordion toggle during editing when there are errors #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
dafe428
EVEREST-1958 | fix resources accordion toggle during editing when the…
Tikdev00 Apr 2, 2025
3497f68
Merge branch 'main' into EVEREST-1958-auto-expanded-sections-revisit-fix
percona-robot Apr 3, 2025
85f255c
Merge branch 'main' into EVEREST-1958-auto-expanded-sections-revisit-fix
percona-robot Apr 4, 2025
fa5266b
Merge branch 'main' into EVEREST-1958-auto-expanded-sections-revisit-fix
percona-robot Apr 7, 2025
5ba9f4c
Merge branch 'main' into EVEREST-1958-auto-expanded-sections-revisit-fix
percona-robot Apr 7, 2025
4bb32eb
Merge branch 'main' into EVEREST-1958-auto-expanded-sections-revisit-fix
percona-robot Apr 7, 2025
69f4e68
Merge branch 'main' into EVEREST-1958-auto-expanded-sections-revisit-fix
percona-robot Apr 8, 2025
7ef1cef
Merge branch 'main' into EVEREST-1958-auto-expanded-sections-revisit-fix
percona-robot Apr 8, 2025
d045ea7
Merge branch 'main' into EVEREST-1958-auto-expanded-sections-revisit-fix
percona-robot Apr 8, 2025
a45dc77
Merge branch 'main' into EVEREST-1958-auto-expanded-sections-revisit-fix
percona-robot Apr 8, 2025
21f2200
Merge branch 'main' into EVEREST-1958-auto-expanded-sections-revisit-fix
percona-robot Apr 9, 2025
71ea726
Merge branch 'main' into EVEREST-1958-auto-expanded-sections-revisit-fix
percona-robot Apr 9, 2025
75ae135
Merge branch 'main' into EVEREST-1958-auto-expanded-sections-revisit-fix
percona-robot Apr 9, 2025
fe50595
Merge branch 'main' into EVEREST-1958-auto-expanded-sections-revisit-fix
percona-robot Apr 10, 2025
cde4bdb
Merge branch 'main' into EVEREST-1958-auto-expanded-sections-revisit-fix
percona-robot Apr 10, 2025
3b920f6
Merge branch 'main' into EVEREST-1958-auto-expanded-sections-revisit-fix
percona-robot Apr 10, 2025
7a7832e
Merge branch 'main' into EVEREST-1958-auto-expanded-sections-revisit-fix
percona-robot Apr 10, 2025
a46383e
Merge branch 'main' into EVEREST-1958-auto-expanded-sections-revisit-fix
percona-robot Apr 14, 2025
eea5f7a
Merge branch 'main' into EVEREST-1958-auto-expanded-sections-revisit-fix
percona-robot Apr 16, 2025
ebcfb88
Merge branch 'main' into EVEREST-1958-auto-expanded-sections-revisit-fix
percona-robot Apr 22, 2025
b7672d5
Merge branch 'main' into EVEREST-1958-auto-expanded-sections-revisit-fix
percona-robot Apr 24, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@
}
setValue(memoryInputName, sizeOptions[resourceSizePerUnit].memory);
}
}, [resourceSizePerUnit, allowDiskInputUpdate, setValue]);

Check warning on line 203 in ui/apps/everest/src/components/cluster-form/resources/resources.tsx

View workflow job for this annotation

GitHub Actions / CI_checks (lint)

React Hook useEffect has missing dependencies: 'cpuInputName', 'diskInputName', 'memoryInputName', and 'sizeOptions'. Either include them or remove the dependency array

useEffect(() => {
if (diskCapacityExceeded) {
Expand All @@ -208,7 +208,7 @@
} else {
clearErrors(diskInputName);
}
}, [diskCapacityExceeded, clearErrors, setError]);

Check warning on line 211 in ui/apps/everest/src/components/cluster-form/resources/resources.tsx

View workflow job for this annotation

GitHub Actions / CI_checks (lint)

React Hook useEffect has a missing dependency: 'diskInputName'. Either include it or remove the dependency array

useEffect(() => {
if (
Expand All @@ -217,7 +217,7 @@
) {
setValue(resourceSizePerUnitInputName, ResourceSize.custom);
}
}, [cpu, setValue]);

Check warning on line 220 in ui/apps/everest/src/components/cluster-form/resources/resources.tsx

View workflow job for this annotation

GitHub Actions / CI_checks (lint)

React Hook useEffect has missing dependencies: 'resourceSizePerUnit', 'resourceSizePerUnitInputName', and 'sizeOptions'. Either include them or remove the dependency array

useEffect(() => {
if (
Expand All @@ -227,7 +227,7 @@
) {
setValue(resourceSizePerUnitInputName, ResourceSize.custom);
}
}, [disk, allowDiskInputUpdate, setValue]);

Check warning on line 230 in ui/apps/everest/src/components/cluster-form/resources/resources.tsx

View workflow job for this annotation

GitHub Actions / CI_checks (lint)

React Hook useEffect has missing dependencies: 'resourceSizePerUnit', 'resourceSizePerUnitInputName', and 'sizeOptions'. Either include them or remove the dependency array

useEffect(() => {
if (
Expand All @@ -236,7 +236,7 @@
) {
setValue(resourceSizePerUnitInputName, ResourceSize.custom);
}
}, [memory, setValue]);

Check warning on line 239 in ui/apps/everest/src/components/cluster-form/resources/resources.tsx

View workflow job for this annotation

GitHub Actions / CI_checks (lint)

React Hook useEffect has missing dependencies: 'resourceSizePerUnit', 'resourceSizePerUnitInputName', and 'sizeOptions'. Either include them or remove the dependency array

return (
<FormGroup sx={{ mt: 3 }}>
Expand Down Expand Up @@ -631,6 +631,14 @@
trigger();
}, [numberOfNodes, customNrOfNodes, trigger, numberOfProxies]);

useEffect(() => {
if (someErrorInNodes && !someErrorInProxies) {
setExpanded('nodes');
} else if (someErrorInProxies && !someErrorInNodes) {
setExpanded('proxies');
}
}, [expanded, someErrorInNodes, someErrorInProxies]);

// TODO test the following:
// when in restore mode, the number of shards should be disabled
return (
Expand Down
Loading