-
Notifications
You must be signed in to change notification settings - Fork 17
EVEREST-1925 Blocklisting mechanism #1293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
oksana-grishchenko
wants to merge
14
commits into
EVEREST-1923-new-logout-flow
Choose a base branch
from
EVEREST-1925-blacklisting-mechanism
base: EVEREST-1923-new-logout-flow
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
EVEREST-1925 Blocklisting mechanism #1293
oksana-grishchenko
wants to merge
14
commits into
EVEREST-1923-new-logout-flow
from
EVEREST-1925-blacklisting-mechanism
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+62
to
+67
'429': | ||
description: Too many attempts | ||
content: | ||
application/json: | ||
schema: | ||
$ref: '#/components/schemas/Error' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the endpoint already can return 429 status, but it wasn't reflected in the API spec
…ism' into EVEREST-1925-blacklisting-mechanism
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When user logs out, their token remains valid until its natural expiration time specified in the token itself. For the built-in Everest authentication the token lifetime is 24h which introduces security concerns even though the built-in authentication is not recommended for the production use.
Solution:
Implement the blocklisting mechanism according to the proposal
This PR does:
DELETE /session
endpoint, which adds the current token information to the blacklistDELETE /session
endpoint. The rate limiting rule which was applied to thePOST /session endpoint
is now applied to theDELETE /session
as well, for more details see EVEREST-1157 Add /session rate limits #530