Skip to content

PMM-14843: alternative renderer sidebar hide #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fabio-silva merged 4 commits into from
Mar 19, 2026
Merged

PMM-14843: alternative renderer sidebar hide #883

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dedf0c2
chore: assert for "render=1"
fabio-silva Mar 11, 2026
12a7871
fix: test
fabio-silva Mar 11, 2026
e3ee65a
Merge branch 'main' into PMM-14843-alternative-renderer-sidebar-hide
fabio-silva Mar 11, 2026
9eab39b
Merge branch 'main' into PMM-14843-alternative-renderer-sidebar-hide
matejkubinec Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pkg/services/rendering/rendering_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,13 @@ func TestGetUrl(t *testing.T) {
Cfg: cfg,
}

// @PERCONA we need to make sure this query param is present for the sidebar not to show
t.Run("When renderer url is configured should return render=1", func(t *testing.T) {
rs.Cfg.RendererUrl = "http://localhost:8081/render"
url := rs.getGrafanaCallbackURL(path)
require.Equal(t, path+"&render=1", url)
})

t.Run("When renderer and callback url configured should return callback url plus path", func(t *testing.T) {
rs.Cfg.RendererUrl = "http://localhost:8081/render"
rs.Cfg.RendererCallbackUrl = "http://public-grafana.com/"
Expand Down
Loading