PMM-14618 Add disable collectors field to MySQL/PG/RDS/Mongo/ProxySQL#904
Open
matejkubinec wants to merge 4 commits into
Open
PMM-14618 Add disable collectors field to MySQL/PG/RDS/Mongo/ProxySQL#904matejkubinec wants to merge 4 commits into
matejkubinec wants to merge 4 commits into
Conversation
Add an optional "Disable collectors" text field to the Additional options section of the add-instance forms. Users enter a comma-delimited list of collector names (spaces allowed), which is parsed into a string array on submit. - MySQL/PostgreSQL: maps to disable_collectors - RDS: maps to mysql_disable_collectors / postgresql_disable_collectors - MongoDB/ProxySQL: maps to disable_collectors (added a ProxySQL case) - Hidden for Azure flows (unsupported) Add a disableCollectors form validator (+ unit test) that allows letters, digits, "_", ".", "-" per collector name.
There was a problem hiding this comment.
Pull request overview
Adds a new optional “Disable collectors” text field to the Add Remote Instance flows (MySQL, PostgreSQL, RDS, MongoDB, ProxySQL), validates the comma-delimited input, and converts it into the array format expected by the backend payload.
Changes:
- Added a new
disableCollectorsform validator (+ unit test) and exported it fromvalidatorsForm. - Added “Disable collectors” label/placeholder/tooltip strings and rendered the new field across relevant add-instance additional options (hidden for Azure flows).
- Updated
toPayloadto parse comma-delimited collector strings into string arrays, and introduced new RDS payload fields for engine-specific disable-collectors keys.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| public/app/percona/shared/helpers/validatorsForm/index.ts | Exports the new disableCollectors validator. |
| public/app/percona/shared/helpers/validatorsForm/disableCollectors.ts | Implements validation for comma-delimited collector names. |
| public/app/percona/shared/helpers/validatorsForm/disableCollectors.test.ts | Adds unit tests for the new validator. |
| public/app/percona/add-instance/components/AddRemoteInstance/FormParts/FormParts.messages.ts | Adds UI strings (label/placeholder/tooltip) for the new field. |
| public/app/percona/add-instance/components/AddRemoteInstance/FormParts/AdditionalOptions/AdditionalOptions.tsx | Adds the new input field to relevant add-instance forms and wires validator/tooltips. |
| public/app/percona/add-instance/components/AddRemoteInstance/AddRemoteInstance.types.ts | Adds RDS payload fields for disable-collectors. |
| public/app/percona/add-instance/components/AddRemoteInstance/AddRemoteInstance.service.tsx | Parses disable-collectors string fields into arrays in toPayload. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Type disableCollectors validator as Validator<string | undefined> and drop the unsafe any cast in its test - Make RDS mysql_/postgresql_disable_collectors payload fields optional - Add toPayload test covering comma string parsing (trim + filter empty) - Extract shared DisableCollectorsField component using a description instead of a tooltip; reposition the MySQL field below Extra DSN params and above the table statistics limit - Drop underscores from the placeholder example for consistency Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
matejkubinec
commented
May 29, 2026
Collaborator
Author
There was a problem hiding this comment.
@catalinaadam when you have time, please take a look at the wording here if it's alright
There was a problem hiding this comment.
Hi @matejkubinec, the label and placeholder look good. I'd suggest updating the description to explain the purpose rather than just the format:
Current:
Comma-separated list of collector names to disable for this exporter. Leave empty to keep all collectors enabled.
Suggested:
Exclude specific collectors from metric collection to reduce monitoring overhead or suppress metrics not relevant to your environment. Leave empty to keep all collectors enabled.
…sible, wrap description text
mattiasimonato
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PMM-14618
FB: SUBMODULES-4377
Add an optional "Disable collectors" text field to the Additional options
section of the add-instance forms. Users enter a comma-delimited list of
collector names (spaces allowed), which is parsed into a string array on
submit.
Add a disableCollectors form validator (+ unit test) that allows letters,
digits, "_", ".", "-" per collector name.
Screenshots:
