Update default Secrets name for system users#363
Open
rajaie7 wants to merge 1 commit into
Open
Conversation
seems the current docs reference an incorrect default secret name for system users. https://github.com/percona/percona-server-mongodb-operator/blob/59bf8a93133323f37bf0688d47f56cb16432f850/pkg/apis/psmdb/v1/psmdb_defaults.go#L47
rajaie7
requested review from
egegunes,
eleo007,
gkech,
hors,
jvpasinatto,
mayankshah1607,
nastena1606,
nmarukovich,
pooknull and
valmiranogueira
as code owners
July 16, 2026 13:50
egegunes
requested changes
Jul 17, 2026
Contributor
There was a problem hiding this comment.
@rajaie7 the default secrets name is <cr.Name>-secrets. Example cr.yaml in our repo is named my-cluster-name so my-cluster-name-secrets is correct.
Yes, if you don't specify secrets.users, the default name is percona-server-mongodb-secrets. I think this is wrong and we need to change the default name to <cr.Name>-secrets to be consistent across operators.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
seems the current docs reference an incorrect default secret name for system users. https://github.com/percona/percona-server-mongodb-operator/blob/59bf8a93133323f37bf0688d47f56cb16432f850/pkg/apis/psmdb/v1/psmdb_defaults.go#L47