PMM Separate histogram from diagnostic_data collector.#1323
Merged
Conversation
This was referenced Jul 23, 2026
Contributor
Author
|
@copilot review |
Express the histogram-skip policy once at descent time via isHistogramPath, and keep makeMetrics' original signature so only the diagnostic_data collector deals with the histograms flag.
Satisfies the tagalign linter flagged by reviewdog on the PR.
ademidoff
approved these changes
Jul 24, 2026
ademidoff
marked this pull request as ready for review
July 24, 2026 09:15
ademidoff
requested review from
4nte and
maxkondr
and removed request for
a team
July 24, 2026 09:15
maxkondr
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PMM-15246
PMM PR: percona/pmm#5690
FB: Percona-Lab/pmm-submodules#4494