ppg:staging: pin fork servers to the PSP-X.Y.Z release tags (16.15.1 / 17.11.1 / 18.6.1) - #22
Merged
Conversation
The Percona fork tagged the new releases as PSP-16.15.1 / PSP-17.11.1 /
PSP-18.6.1 instead of the release-X.Y.Z naming used up to 17.10.2 /
18.4.2, so the revision form introduced with PERCONA_PG_PATCH_VERSION
(release-%!{PG_VERSION}.%!{PERCONA_PG_PATCH_VERSION}) keeps resolving
to the release-* *branches* and would never pin itself to a tag.
Switch staging/17, staging/18 and staging/16/tde to
PSP-%!{PG_VERSION}.%!{PERCONA_PG_PATCH_VERSION}. Each PSP tag
currently points at the exact head of the corresponding release-*
branch (PSP-16.15.1 = c0d38ac6, PSP-17.11.1 = d2798ace,
PSP-18.6.1 = 19c3033d), so the built source is unchanged; the
revision just stops being a moving ref, as a staging tier expects.
Signed-off-by: Ricardo Dias <ricardo.dias@percona.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #16: the Percona fork has now tagged the new server releases, but under a new naming scheme —
PSP-16.15.1/PSP-17.11.1/PSP-18.6.1instead of therelease-X.Y.Znames used through 17.10.2 / 18.4.2.That breaks the assumption from #16 that the
release-%!{PG_VERSION}.%!{PERCONA_PG_PATCH_VERSION}revision would pin itself once the same-named tag appeared: the ref that resolves forrelease-17.11.1is still the branch, so staging kept building a moving ref.This switches the three fork consumers (
staging/17,staging/18,staging/16/tde) toPSP-%!{PG_VERSION}.%!{PERCONA_PG_PATCH_VERSION}:PSP-17.11.1d2798acerelease-17.11.1PSP-18.6.119c3033drelease-18.6.1PSP-16.15.1c0d38ac6release-16.15.1Each tag currently sits exactly on its branch head, so the built source is byte-identical — the revision just stops moving. The
version/set_versionparams are untouched (packages stay 17.11 / 18.6 / 16.15). staging/14, 15 and theextrassubprojects build the stock upstream server fromREL_*tags and are not affected.Rendered revisions verified with
percona_obs.common.load_macros().