Conversation
Upstream commit 844379e (post-2.2.1) switched the KMIP support to a new C++ KMIP client library and set cpp_std=c++20 on the pg_tde targets. meson only knows the "c++20" value from 0.57 on, so meson 0.56.2 on Debian 11 aborts at configure time with: ERROR: Value "c++20" ... is not one of the choices Carry a Debian packaging patch (3.0 quilt) that switches the two override_options to the pre-ratification spelling "c++2a", which meson 0.56 accepts and gcc/clang treat identically to c++20. The libkmip cmake subproject needs no change: cmake already emits -std=c++2a for CMAKE_CXX_STANDARD 20 on gcc 10. Verified by container builds against the published staging:18 repos: all 118 targets compile and link on both Debian 11 (meson 0.56.2, g++ 10) and Debian 13 (meson 1.7.0, g++ 14). Signed-off-by: Ricardo Dias <ricardo.dias@percona.com>
Upstream commit 844379e (post-2.2.1) made pg_tde need a C++ compiler for the new C++ KMIP client library. On openSUSE Tumbleweed and Leap 16 the spec never installed one, so meson fell back to clang++ (present only via the llvmjit BuildRequires) while C was still compiled by gcc. With SUSE's default -flto=auto that mixed toolchain cannot be linked: gcc-ar cannot index clang LLVM bitcode archives and clang's ld.bfd cannot read gcc LTO objects, failing with libkmipclient.a: error adding symbols: archive has no index plugin needed to handle lto object Add gcc-c++ to the suse_version BuildRequires so meson picks c++ (g++) and the whole build uses one toolchain. Verified in a Tumbleweed container against the published staging:18 repo with clang installed and -flto=auto in C/CXX/LDFLAGS: meson selects c++ (gcc 15.3.0), all targets link, pg_tde.so is produced. Signed-off-by: Ricardo Dias <ricardo.dias@percona.com>
rjd15372
added
openSUSE_Leap_16
openSUSE_Tumbleweed
no-dep-cascade
|
|
OBS Build Check — ⏱️ Build polling cancelledPackages for this PR are being built at isv:percona:PR:pr-3.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.