PMM-14410 - Miscellaneous improvements on pmm-ha #676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove duplicate validation check for tls.validityDays in haproxy-tls-secret.yaml
…t it should reference the secret whenever a secret name is provided.
- Set configSecretName at the top level to work around a chart bug. - Update vmauth configSecretName to a static value for consistency. - Change replicaCount to replicas in ci-values.yaml for clarity.
- Updated values.yaml to clarify Keeper cluster name restrictions. - Added validation checks for ClickHouse and Keeper cluster names in templates to ensure they are non-empty, alphanumeric, and within the 15 character limit.
- Swapped the PMM server image repository to perconalab/pmm-server-fb. - Updated the image tag to PR-4078-f8820d4 for better version tracking. - Enhanced comments in pmmEnv section for clarity on dynamic variables. - Added detailed comments for OAuth client ID and secret configuration in the secret section. - Corrected a typo in the comment for nginx SSL certificates in secret-certs.yaml.
theTibi
requested review from
BupycHuk and
JiriCtvrtka
and removed request for
a team
JiriCtvrtka
reviewed
Oct 24, 2025
| ## E.g. | ||
| ## GF_AUTH_GENERIC_OAUTH_CLIENT_ID: "my-oauth-client-id" | ||
| ## | ||
| GF_AUTH_GENERIC_OAUTH_CLIENT_ID: "" |
Contributor
There was a problem hiding this comment.
Is it left empty on purpose for now since it’s uncommented?
JiriCtvrtka
approved these changes
Oct 24, 2025
…m statefulset.yaml and update comments in values.yaml for clarity on dynamic variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.