EVEREST-2365 | provide mechanism to skip validating/mutating webhooks #705
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Everest cannot be installed using Helm v4.
Cause
Helm v4 introduces a breaking change in the manifest installation order. In Helm v3,
ValidatingWebhookConfigurationandMutatingWebhookConfigurationresources were not considered during resource ordering. As a result, theLoadBalancerConfigmanifest was applied before the webhook configuration (due to alphabetical ordering of resource kinds), so it was not subject to admission review.With Helm v4, these webhook configurations are now taken into account, and all unknown resource kinds (such as
LoadBalancerConfig) are applied after the webhook. SinceLoadBalancerConfigis subject to admission review by ourValidatingWebhookConfiguration, the installation fails because the Everest operator is not yet running when the webhook is invoked.Solution
Admission webhooks are now configured to skip validation for objects that have specific labels. This allows the
LoadBalancerConfigto be created during installation without triggering admission review.