Skip to content

Conversation

@knechtionscoding
Copy link

@knechtionscoding knechtionscoding commented Dec 2, 2025

The labels are currently incorrectly indented resulting in the labels themselves landing at the same layer as the labels key. This bumps them out 2 more to be correctly indented.

old:

---
# Source: pmm/templates/clusterrole.yaml
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  name: test-pmm
  namespace: bootstrapping-operator
  labels:
  helm.sh/chart: pmm-1.4.14
  app.kubernetes.io/name: pmm
  app.kubernetes.io/instance: test
  app.kubernetes.io/component: pmm-server
  app.kubernetes.io/part-of: percona-platform
  app.kubernetes.io/version: "3.5.0"
  app.kubernetes.io/managed-by: Helm

new:

# Source: pmm/templates/clusterrole.yaml
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  name: test-pmm
  namespace: bootstrapping-operator
  labels:
    helm.sh/chart: pmm-1.4.14
    app.kubernetes.io/name: pmm
    app.kubernetes.io/instance: test
    app.kubernetes.io/component: pmm-server
    app.kubernetes.io/part-of: percona-platform
    app.kubernetes.io/version: "3.5.0"
    app.kubernetes.io/managed-by: Helm

@knechtionscoding knechtionscoding requested a review from a team as a code owner December 2, 2025 09:47
@knechtionscoding knechtionscoding requested review from JiriCtvrtka and idoqo and removed request for a team December 2, 2025 09:47
@it-percona-cla
Copy link

it-percona-cla commented Dec 2, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@ademidoff ademidoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing 👍

@knechtionscoding
Copy link
Author

@ademidoff thanks for the approval! Do you merge or someone else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants