Skip to content

Fix: Correct label indentation in PMM clusterrole.yaml#831

Open
ericsanjaya wants to merge 3 commits into
percona:mainfrom
tohjiwateknologi:main
Open

Fix: Correct label indentation in PMM clusterrole.yaml#831
ericsanjaya wants to merge 3 commits into
percona:mainfrom
tohjiwateknologi:main

Conversation

@ericsanjaya

Copy link
Copy Markdown

Using a 2-space indentation for labels in clusterrole.yaml results in malformed YAML output, as shown below:

# Source: pmm/templates/clusterrole.yaml
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  name: pmm
  namespace: default
  labels:
  helm.sh/chart: pmm-1.6.0
  app.kubernetes.io/name: pmm
  app.kubernetes.io/instance: pmm
  app.kubernetes.io/component: pmm-server
  app.kubernetes.io/part-of: percona-platform
  app.kubernetes.io/version: "3.7.0"
  app.kubernetes.io/managed-by: Helm

This incorrect nesting causes the Helm validation process to fail. This PR reverts the indentation for the labels section back to 4 spaces to ensure the manifest is valid.

Related Issue
#762

Revert to 4 indentation for labels in clusterrole.yaml
@ericsanjaya
ericsanjaya requested a review from a team as a code owner April 11, 2026 07:02
@ericsanjaya
ericsanjaya requested review from JiriCtvrtka and maxkondr and removed request for a team April 11, 2026 07:02
@it-percona-cla

it-percona-cla commented Apr 11, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants