Fix: Correct label indentation in PMM clusterrole.yaml#831
Open
ericsanjaya wants to merge 3 commits into
Open
Conversation
Revert to 4 indentation for labels in clusterrole.yaml
ericsanjaya
requested review from
JiriCtvrtka and
maxkondr
and removed request for
a team
April 11, 2026 07:02
JiriCtvrtka
approved these changes
May 1, 2026
maxkondr
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a 2-space indentation for labels in clusterrole.yaml results in malformed YAML output, as shown below:
This incorrect nesting causes the Helm validation process to fail. This PR reverts the indentation for the labels section back to 4 spaces to ensure the manifest is valid.
Related Issue
#762