Skip to content

K8SPS-716: add .spec.pitr.backupSource.binlogServer to the ps-restore#857

Open
pooknull wants to merge 16 commits into
mainfrom
K8SPS-716
Open

K8SPS-716: add .spec.pitr.backupSource.binlogServer to the ps-restore#857
pooknull wants to merge 16 commits into
mainfrom
K8SPS-716

Conversation

@pooknull

Copy link
Copy Markdown
Contributor

@pooknull
pooknull requested review from hors and nmarukovich as code owners May 22, 2026 11:02
Copilot AI review requested due to automatic review settings May 22, 2026 11:02
@github-actions github-actions Bot added ps operators a label used for the prs opened for the operators labels May 22, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the ps-operator Helm chart CRDs to extend the PerconaServerMySQLRestore API so PITR restores can carry a binlogServer configuration under .spec.pitr.backupSource.

Changes:

  • Added .spec.pitr.backupSource.binlogServer schema to the PerconaServerMySQLRestore CRD (ps-restore).
  • Removed the CRD validation that required .spec.pitr.binlogServer when .spec.pitr.enabled is set (in the PerconaServerMySQL CRD).
Comments suppressed due to low confidence (1)

charts/ps-operator/crds/crd.yaml:5267

  • The validation that required spec.pitr.binlogServer when spec.pitr.enabled is true was removed. With the remaining rules structured as ... || !has(self.binlogServer) || (...), a user can now set enabled: true without providing any binlogServer config and still pass CRD validation, which is likely to result in an invalid PITR setup at runtime. Consider restoring the requirement (or adjusting the remaining rules so that binlogServer itself is required when enabled, or explicitly documenting/validating an alternative source).
                    x-kubernetes-validations:
                    - message: binlogServer.image is required when pitr is enabled
                      rule: '!(has(self.enabled) && self.enabled) || !has(self.binlogServer)
                        || (has(self.binlogServer.image) && self.binlogServer.image
                        != '''')'

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mayankshah1607 and others added 9 commits June 23, 2026 08:48
Signed-off-by: Mayank Shah <mayank.shah@percona.com>
* Add support for haproxy sidecar resources config

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Remove claims from doc

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* K8SPS-496: add allocateLoadBalancerNodePorts

* Fix README
Co-authored-by: Valmira Nogueira Corrêa <valmira.nogueira@percona.com>
* update crds

Signed-off-by: Mayank Shah <mayank.shah@percona.com>

* update rbac

Signed-off-by: Mayank Shah <mayank.shah@percona.com>

* update deployment

Signed-off-by: Mayank Shah <mayank.shah@percona.com>

* update crd

Signed-off-by: Mayank Shah <mayank.shah@percona.com>

* syntax error

Signed-off-by: Mayank Shah <mayank.shah@percona.com>

---------

Signed-off-by: Mayank Shah <mayank.shah@percona.com>
Co-authored-by: Julio Pasinatto <julio.pasinatto@percona.com>
Copilot AI review requested due to automatic review settings July 2, 2026 10:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

charts/ps-operator/crds/crd.yaml:5271

  • The validation rules here allow pitr.enabled: true with no binlogServer configured (!has(self.binlogServer) short-circuits), but the error messages still state binlogServer.image/size is required when pitr is enabled. This mismatch is confusing for users and makes it look like CRD validation is stricter than it actually is.
                    - message: binlogServer.image is required when pitr is enabled
                      rule: '!(has(self.enabled) && self.enabled) || !has(self.binlogServer)
                        || (has(self.binlogServer.image) && self.binlogServer.image
                        != '''')'
                    - message: binlogServer.size is required when pitr is enabled
                      rule: '!(has(self.enabled) && self.enabled) || !has(self.binlogServer)
                        || (has(self.binlogServer.size) && self.binlogServer.size
                        > 0)'

jvpasinatto and others added 2 commits July 2, 2026 10:24
* update crds

Signed-off-by: Mayank Shah <mayank.shah@percona.com>

* update ps-db

Signed-off-by: Mayank Shah <mayank.shah@percona.com>

* remove comments from values.yaml

Signed-off-by: Mayank Shah <mayank.shah@percona.com>

* apply fields selectively

Signed-off-by: Mayank Shah <mayank.shah@percona.com>

* removed enableVolumeExpansion from readme

Signed-off-by: Mayank Shah <mayank.shah@percona.com>

---------

Signed-off-by: Mayank Shah <mayank.shah@percona.com>
Co-authored-by: Julio Pasinatto <julio.pasinatto@percona.com>
@jvpasinatto
jvpasinatto changed the base branch from main to release-ps-1.2.0 July 2, 2026 14:44
@github-actions github-actions Bot removed ps operators a label used for the prs opened for the operators labels Jul 2, 2026
Base automatically changed from release-ps-1.2.0 to main July 3, 2026 17:51
@jvpasinatto jvpasinatto added ps operators a label used for the prs opened for the operators labels Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

operators a label used for the prs opened for the operators ps

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants