Conversation
pooknull
requested review from
eleo007,
jvpasinatto and
valmiranogueira
as code owners
May 22, 2026 11:02
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the ps-operator Helm chart CRDs to extend the PerconaServerMySQLRestore API so PITR restores can carry a binlogServer configuration under .spec.pitr.backupSource.
Changes:
- Added
.spec.pitr.backupSource.binlogServerschema to thePerconaServerMySQLRestoreCRD (ps-restore). - Removed the CRD validation that required
.spec.pitr.binlogServerwhen.spec.pitr.enabledis set (in thePerconaServerMySQLCRD).
Comments suppressed due to low confidence (1)
charts/ps-operator/crds/crd.yaml:5267
- The validation that required
spec.pitr.binlogServerwhenspec.pitr.enabledis true was removed. With the remaining rules structured as... || !has(self.binlogServer) || (...), a user can now setenabled: truewithout providing anybinlogServerconfig and still pass CRD validation, which is likely to result in an invalid PITR setup at runtime. Consider restoring the requirement (or adjusting the remaining rules so thatbinlogServeritself is required when enabled, or explicitly documenting/validating an alternative source).
x-kubernetes-validations:
- message: binlogServer.image is required when pitr is enabled
rule: '!(has(self.enabled) && self.enabled) || !has(self.binlogServer)
|| (has(self.binlogServer.image) && self.binlogServer.image
!= '''')'
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Mayank Shah <mayank.shah@percona.com>
* Add support for haproxy sidecar resources config * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Remove claims from doc --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Valmira Nogueira Corrêa <valmira.nogueira@percona.com>
* update crds Signed-off-by: Mayank Shah <mayank.shah@percona.com> * update rbac Signed-off-by: Mayank Shah <mayank.shah@percona.com> * update deployment Signed-off-by: Mayank Shah <mayank.shah@percona.com> * update crd Signed-off-by: Mayank Shah <mayank.shah@percona.com> * syntax error Signed-off-by: Mayank Shah <mayank.shah@percona.com> --------- Signed-off-by: Mayank Shah <mayank.shah@percona.com> Co-authored-by: Julio Pasinatto <julio.pasinatto@percona.com>
jvpasinatto
requested review from
egegunes,
gkech,
mayankshah1607 and
oksana-grishchenko
as code owners
July 2, 2026 10:15
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
charts/ps-operator/crds/crd.yaml:5271
- The validation rules here allow
pitr.enabled: truewith nobinlogServerconfigured (!has(self.binlogServer)short-circuits), but the error messages still statebinlogServer.image/size is required when pitr is enabled. This mismatch is confusing for users and makes it look like CRD validation is stricter than it actually is.
- message: binlogServer.image is required when pitr is enabled
rule: '!(has(self.enabled) && self.enabled) || !has(self.binlogServer)
|| (has(self.binlogServer.image) && self.binlogServer.image
!= '''')'
- message: binlogServer.size is required when pitr is enabled
rule: '!(has(self.enabled) && self.enabled) || !has(self.binlogServer)
|| (has(self.binlogServer.size) && self.binlogServer.size
> 0)'
* update crds Signed-off-by: Mayank Shah <mayank.shah@percona.com> * update ps-db Signed-off-by: Mayank Shah <mayank.shah@percona.com> * remove comments from values.yaml Signed-off-by: Mayank Shah <mayank.shah@percona.com> * apply fields selectively Signed-off-by: Mayank Shah <mayank.shah@percona.com> * removed enableVolumeExpansion from readme Signed-off-by: Mayank Shah <mayank.shah@percona.com> --------- Signed-off-by: Mayank Shah <mayank.shah@percona.com> Co-authored-by: Julio Pasinatto <julio.pasinatto@percona.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/K8SPS-716