feature(helm): add gateway api support#903
Open
rkferreira wants to merge 6 commits into
Open
Conversation
Signed-off-by: Rodrigo Kellermann <kellermann@gmail.com>
rkferreira
requested review from
4nte and
ademidoff
and removed request for
a team
July 13, 2026 20:31
Author
|
Sample values config for pmm chart: |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Gateway API (HTTPRoute) support to the pmm and pmm-ha Helm charts to enable advanced HTTP and gRPC routing via Gateway API, alongside existing Ingress support.
Changes:
- Introduces new
gateway-httproute.yamltemplates to render HTTPRoute resources whengateway.enabledis set. - Adds a new
gatewayvalues section in both charts to configure parentRefs, hosts/path mappings, annotations, and pathType. - Updates service rendering logic to create the additional backend service when either Ingress or Gateway API is enabled, and bumps chart patch versions.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/pmm/values.yaml | Adds gateway configuration values for HTTPRoute generation. |
| charts/pmm/templates/service.yaml | Extends conditional service exposure to also trigger for Gateway API. |
| charts/pmm/templates/gateway-httproute.yaml | New HTTPRoute template for Gateway API routing (HTTP + gRPC path mapping). |
| charts/pmm/Chart.yaml | Patch version bump (1.8.1 → 1.8.2). |
| charts/pmm-ha/values.yaml | Adds gateway configuration values for HTTPRoute generation. |
| charts/pmm-ha/templates/service.yaml | Extends conditional service exposure to also trigger for Gateway API. |
| charts/pmm-ha/templates/gateway-httproute.yaml | New HTTPRoute template for Gateway API routing (HTTP + gRPC path mapping). |
| charts/pmm-ha/Chart.yaml | Patch version bump (1.5.1 → 1.5.2). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Rodrigo Kellermann <kellermann@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
charts/pmm-ha/templates/service.yaml:31
- The condition was expanded to include Gateway API, but the comment block below still refers only to ingress (and also implies this service is used for both HTTP and gRPC). Update the comments so they accurately reflect when/why this Service is created.
{{- if or .Values.ingress.enabled .Values.gateway.enabled }}
---
# Regular ClusterIP service for ingress routing
# Note: Both HTTP and gRPC traffic use this service when ingress is enabled
apiVersion: v1
Author
|
I have to double check all the copilot comments... |
Signed-off-by: Rodrigo Kellermann <kellermann@gmail.com>
Signed-off-by: Rodrigo Kellermann <kellermann@gmail.com>
rkferreira
force-pushed
the
feature/bring-gateway-api-support
branch
from
July 17, 2026 21:38
2bf4ad8 to
1138bb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds Gateway API support to both the
pmmandpmm-haHelm charts, allowing configuration of HTTPRoute resources for advanced ingress and gRPC routing via the Gateway API. It introduces new templates and values to enable, configure, and map HTTP and gRPC paths, and ensures that services are exposed correctly when either Ingress or Gateway API is enabled. Additionally, both charts receive a patch version bump.Gateway API integration:
gateway-httproute.yamltemplate to bothcharts/pmm/templates/andcharts/pmm-ha/templates/for generating HTTPRoute resources when Gateway API is enabled. This template supports custom host/path routing and gRPC path handling. [1] [2]gatewaysection in bothcharts/pmm/values.yamlandcharts/pmm-ha/values.yamlfor configuring Gateway API options such as enabling/disabling, annotations, parentRefs, hosts, paths, and pathType. [1] [2]Service exposure logic:
service.yamlin both charts to expose the ClusterIP service when either Ingress or Gateway API is enabled, ensuring correct routing for both HTTP and gRPC traffic. [1] [2]Version bumps:
charts/pmm/Chart.yamlversion from1.8.1to1.8.2.charts/pmm-ha/Chart.yamlversion from1.5.1to1.5.2.Fixes #902