Split up linter checks and unit tests - #931
Merged
Merged
Conversation
The unit-test matrix shared .github/workflows/test.yaml with lint-test, so it ran on every PR the lint job covers, including PMM-only changes. GitHub has no per-job path filter, so move the matrix to its own workflow scoped to charts/pxc-operator, charts/pxc-db and the Makefile.
ademidoff
requested review from
DhruthiKV,
egegunes,
eleo007,
gkech,
hors,
jvpasinatto,
mayankshah1607,
nmarukovich,
oksana-grishchenko,
pooknull and
valmiranogueira
as code owners
August 19, 2026 16:26
Contributor
There was a problem hiding this comment.
Pull request overview
Splits Helm unit-test execution into a dedicated GitHub Actions workflow so unit tests only run when PXC-related charts (or the Makefile/workflow) change, avoiding unnecessary unit-test runs on unrelated PRs (e.g., PMM-only changes).
Changes:
- Added a new workflow
.github/workflows/unit-test.yamlthat runs the existinghelm-unittestmatrix only whencharts/pxc-operator/**,charts/pxc-db/**,Makefile, or the workflow file itself changes. - Removed the
unit-testjob from.github/workflows/test.yaml, leaving the existinglint-testbehavior and itspaths-ignoreintact.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/unit-test.yaml | New workflow containing the Helm unit-test matrix with path-based triggering scoped to PXC-related charts. |
| .github/workflows/test.yaml | Removes the unit-test job so this workflow only runs lint/chart-testing-related checks. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
hors
pushed a commit
that referenced
this pull request
Aug 19, 2026
* Release PMM 3.9.1 * Run helm-unittest only for the charts that have suites The unit-test matrix shared .github/workflows/test.yaml with lint-test, so it ran on every PR the lint job covers, including PMM-only changes. GitHub has no per-job path filter, so move the matrix to its own workflow scoped to charts/pxc-operator, charts/pxc-db and the Makefile. * chore: trigger the build * Revert "Run helm-unittest only for the charts that have suites" This reverts commit 669803d. The change moved to its own PR (#931) so it can be reviewed on its own instead of riding along with the release bump.
jvpasinatto
approved these changes
Aug 26, 2026
hors
approved these changes
Aug 26, 2026
valmiranogueira
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
helm-unittestmatrix (test-pxc-operator,test-pxc-db) shared.github/workflows/test.yamlwith thelint-testjob, so it ran on every PR thatlint-testcovers — including PMM-only changes, which have no unit-test suites and cannot be affected by them.paths-ignoreon the existing workflow does not solve this: it gates the whole workflow file, andlint-testin that same file is exactly what coverscharts/pmm. GitHub Actions has no per-job path filter, so the matrix moves to its own workflow instead.Changes:
.github/workflows/unit-test.yamlwith theunit-testmatrix, triggered only bycharts/pxc-operator/**,charts/pxc-db/**,Makefile, and the workflow file itself.unit-testjob from.github/workflows/test.yaml;lint-testand itspaths-ignorelist are untouched.This mirrors the pattern already used by
.github/workflows/pmm-ha-pr-checks.yaml. The jobname:is unchanged, so the checks still report asHelm Unit Tests (test-pxc-operator)andHelm Unit Tests (test-pxc-db).Note: adding a chart with unit-test suites now means adding a
test-<chart>target to theMakefile, a matrix entry and apaths:trigger in.github/workflows/unit-test.yaml.Verified on #930, where both jobs ran green from the new workflow.