This repository was archived by the owner on Jan 15, 2021. It is now read-only.
Use = for [ ... ] tests instead of bash's == #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Bash, the builtin command `test` resp. `[` accepts both `==` as well as `=` as an operator. POSIX however only specifies `=`. Thus, if the scripts are used with a `/bin/sh` which is not Bash, e.g. dash on Debian derivates, the test fail with: [: 1: unexpected operator This commit ensures that only the POSIX-conformiing operator `=` is used. For Bash, it doesn't make any difference, for other shells, it ensures that the scripts still work.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bash, the builtin command
testresp.[accepts both==as well as=as an operator. POSIX however only specifies=. Thus, if the scripts are used with a/bin/shwhich is not Bash, e.g. dash on Debian derivates, the test fail with:This commit ensures that only the POSIX-conformiing operator
=is used. For Bash, it doesn't make any difference, for other shells, it ensures that the scripts still work.This pull request is an alternative solution to #36 and should fix #17 and (at least part of) #32.