Skip to content

K8SPG-615: Add initialDelaySeconds for backups #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

egegunes
Copy link
Contributor

@egegunes egegunes commented Apr 9, 2025

K8SPG-615 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:
In some environments, backup pod can be scheduled to a node but might need some time to be able to reach API server.

Solution:
We're introducing a new field to delay starting backup after pod is scheduled. If user configures spec.backups.pgbackrest.manual.initialDelaySeconds, backup process will wait for configured time before connecting to API server and starting the backup. Sleep duration will be printed in backup container logs:

time="2025-04-09T08:40:28Z" level=info msg="sleeping for 30 seconds"

Helm chart PR: percona/percona-helm-charts#522

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PG version?
  • Does the change support oldest and newest supported Kubernetes version?

@hors hors added this to the 2.7.0 milestone Apr 9, 2025
gkech
gkech previously approved these changes Apr 10, 2025
hors
hors previously approved these changes Apr 10, 2025
nmarukovich
nmarukovich previously approved these changes Apr 14, 2025
@egegunes egegunes dismissed stale reviews from nmarukovich, hors, and gkech via 80def36 April 15, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants