K8SPG-1080 v3 module#1686
Open
oksana-grishchenko wants to merge 40 commits into
Open
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
egegunes
requested changes
Jul 17, 2026
| @@ -9,10 +9,10 @@ import ( | |||
|
|
|||
| var ( | |||
| // GroupVersion is group version used to register these objects | |||
| GroupVersion = schema.GroupVersion{Group: "pgv2.percona.com", Version: "v2"} | |||
| GroupVersion = schema.GroupVersion{Group: "pgv3.percona.com", Version: "v2"} | |||
Contributor
There was a problem hiding this comment.
we don't want to change this and don't need to to use v3 in go
Contributor
Author
There was a problem hiding this comment.
Done, thanks! Some files now contain only the changes related to linter errors (so no changes related explicitely to this PR) however I think it's still beneficial to keep the changes to have less problems in the future.
# Conflicts: # internal/controller/postgrescluster/watches.go # pkg/apis/pgv2.percona.com/v2/perconapgcluster_types.go
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 267 out of 267 changed files in this pull request and generated 6 comments.
Comments suppressed due to low confidence (1)
internal/controller/postgrescluster/pki.go:77
reconcileRootCertificateno longer checks for the legacy root CA secret name (naming.RootCertSecret), even though that constant is still documented as required for upgrades (K8SPG-555). This can cause an operator upgrade to silently mint a new CA instead of reusing/migrating the existing one, breaking client connections.
Comment on lines
50
to
52
| FROM registry.access.redhat.com/${BASE_IMAGE}/ubi-minimal AS ubi | ||
| RUN microdnf update -y && microdnf clean all -y | ||
| RUN microdnf update -y && microdnf clean all -y || true | ||
|
|
Contributor
Author
There was a problem hiding this comment.
reverted
oksana-grishchenko
marked this pull request as ready for review
July 21, 2026 05:52
oksana-grishchenko
requested review from
DhruthiKV,
eleo007,
gkech,
hors,
jvpasinatto,
mayankshah1607,
nmarukovich,
pooknull and
valmiranogueira
as code owners
July 21, 2026 05:52
egegunes
reviewed
Jul 22, 2026
| @@ -1,4 +1,4 @@ | |||
| ARG BASE_IMAGE=ubi10 | |||
| ARG BASE_IMAGE=ubi9 | |||
Contributor
Author
There was a problem hiding this comment.
Ooops, thanks for noticing. I need this change locally in order to build image on Mac and sometimes I commit it mistakenly. Reverted.
Collaborator
commit: dd73068 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v3 module
Problem:
K8SPG-1080
PG 3.0.0 is released while go module still references v2 which makes it harder to use it.
Solution:
Implement v3 module
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability