Conversation
pooknull
requested review from
DhruthiKV,
egegunes,
eleo007,
gkech,
hors,
jvpasinatto,
mayankshah1607,
nmarukovich,
oksana-grishchenko and
valmiranogueira
as code owners
July 16, 2026 13:11
pooknull
marked this pull request as draft
July 16, 2026 13:29
pooknull
marked this pull request as ready for review
July 20, 2026 20:23
egegunes
approved these changes
Jul 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds repo-host (pgBackRest) PVC autoscaling support to the operator, mirroring the existing pgdata autogrow behavior by having the repo-host Pod suggest a larger size via annotations and having the controller apply the resized PVC request while persisting the latest suggestion in status.
Changes:
- Add repo-host monitoring script that periodically computes and PATCHes
suggested-pgbackrest-<repo>-pvc-sizeannotations when volume usage is high (feature-gated). - Teach the PostgresCluster controller to observe suggested sizes from repo-host Pods, cap them by configured limits, apply updated PVC requests, and store the latest suggestion in
status.pgbackrest.repos[].desiredRepoVolume. - Extend repo-host RBAC and add unit + KUTTL E2E coverage for the new behavior.
Reviewed changes
Copilot reviewed 27 out of 28 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/apis/upstream.pgv2.percona.com/v1beta1/pgbackrest_types.go | Adds DesiredRepoVolume to repo status to persist observed suggestions. |
| internal/pgbackrest/reconcile.go | Threads autogrow-enabled repo names into pgBackRest config container script generation. |
| internal/pgbackrest/reconcile_test.go | Unit test ensuring autogrow monitoring is only injected for eligible repos and only on repo-host. |
| internal/pgbackrest/rbac.go | Grants repo-host ServiceAccount patch on pods to allow annotation updates. |
| internal/pgbackrest/rbac_test.go | Updates RBAC test expectations for added patch verb. |
| internal/pgbackrest/config.go | Injects monitor_volume function + per-repo calls into reload loop and PATCHes pod annotations. |
| internal/pgbackrest/config_test.go | Expands shellcheck coverage for reload script with/without autogrow repos. |
| internal/naming/annotations.go | Adds helpers for suggested-size annotation naming and parsing. |
| internal/controller/postgrescluster/watches.go | Triggers reconcile when suggested repo-host volume annotations change. |
| internal/controller/postgrescluster/watches_test.go | Verifies the new watch behavior enqueues reconciliation on suggestion changes. |
| internal/controller/postgrescluster/pgbackrest.go | Observes desired repo volumes from Pods/status, applies capped PVC request changes, persists desired size in status. |
| internal/controller/postgrescluster/pgbackrest_test.go | Adds targeted unit coverage for setRepoVolumeSize and repo-host SA/mount behavior. |
| e2e-tests/tests/repo-host-autogrow/00-deploy-operator.yaml | Enables AutoGrowVolumes in E2E deployment. |
| e2e-tests/tests/repo-host-autogrow/00-assert.yaml | Asserts operator is running before test proceeds. |
| e2e-tests/tests/repo-host-autogrow/01-create-cluster.yaml | Creates cluster with repo PVC request+limit configured to exercise autogrow. |
| e2e-tests/tests/repo-host-autogrow/01-assert.yaml | Waits for cluster + repo-host StatefulSet readiness. |
| e2e-tests/tests/repo-host-autogrow/02-grow-repo-volume.yaml | Fills repo volume to exceed threshold and trigger suggestion logic. |
| e2e-tests/tests/repo-host-autogrow/02-assert.yaml | Asserts suggestion annotation appears and is above expected floor; cleans up fill file. |
| e2e-tests/tests/repo-host-autogrow/03-assert.yaml | Asserts controller persists suggestion into PostgresCluster status and PVC request is updated. |
| e2e-tests/tests/repo-host-autogrow/99-remove-cluster-gracefully.yaml | Cleans up cluster/operator and checks for panics. |
| e2e-tests/run-release.csv | Adds the new E2E test to release runs. |
| e2e-tests/run-pr.csv | Adds the new E2E test to PR runs. |
| deploy/cw-bundle.yaml | CRD bundle regeneration for new status field. |
| deploy/crd.yaml | CRD regeneration for new status field. |
| deploy/bundle.yaml | CRD bundle regeneration for new status field. |
| config/crd/bases/upstream.pgv2.percona.com_postgresclusters.yaml | Base CRD updated with new status field schema. |
| config/crd/bases/pgv2.percona.com_perconapgclusters.yaml | Base CRD updated with new status field schema. |
| build/crd/percona/generated/pgv2.percona.com_perconapgclusters.yaml | Generated CRD updated with new status field schema. |
Comment on lines
+3021
to
+3024
| current, err := resource.ParseQuantity(value) | ||
| if err != nil { | ||
| return nil, errors.Wrap(err, "parse quantity") | ||
| } |
Comment on lines
+580
to
+585
| curl --fail --silent --show-error --cacert "${CACERT}" \ | ||
| --header "Authorization: Bearer ${TOKEN}" \ | ||
| --header "Content-Type: application/merge-patch+json" \ | ||
| --request PATCH \ | ||
| --data "${patch}" \ | ||
| "${APISERVER}/api/v1/namespaces/${NAMESPACE}/pods/${HOSTNAME}" |
mayankshah1607
requested changes
Jul 22, 2026
| ) (map[string]string, error) { | ||
| desired := make(map[string]string) | ||
| if !feature.Enabled(ctx, feature.AutoGrowVolumes) { | ||
| return desired, nil |
Member
There was a problem hiding this comment.
what happens if the flag is disabled after a resize? It looks like we return nil here and later in setRepoVolumeSize we read the size from the spec (not actual pvc size), won't that cause a downscale and possibly break reconciliation?
Collaborator
commit: f566c0d |
oksana-grishchenko
left a comment
oksana-grishchenko
left a comment
Contributor
There was a problem hiding this comment.
Agree with Mayank's concern about disabling feature gate after resizing, that is a possible real life scenario, please consider it.
Other than that LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
This PR adds autoscaling for pgbackrest PVCs. It follows the pgdata PVC autoscaling logic.
When the
AutoGrowVolumesfeature gate is enabled andspec.backups.pgbackrest.repos[].volume.volumeClaimSpec.resources.limits.storageis configured:pgbackrest-configcontainer checks disk usage every five seconds.suggested-pgbackrest-<repo-name>-pvc-sizeresources.requests.storageto the suggested sizestatus.pgbackrest.repos[].desiredRepoVolumeCHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability