Conversation
pooknull
requested review from
egegunes,
gkech,
hors,
mayankshah1607,
nmarukovich and
oksana-grishchenko
as code owners
July 20, 2026 11:38
nmarukovich
approved these changes
Jul 20, 2026
Collaborator
commit: 961c6eb |
egegunes
approved these changes
Jul 21, 2026
mayankshah1607
approved these changes
Jul 22, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the PGBackup controller reconciliation flow so that if the referenced PerconaPGCluster is missing or terminating while a backup is in progress, the backup transitions to Failed, its lease is released, and backup finalizers (including snapshot-related ones) can be removed to avoid leaving the backup stuck in Running.
Changes:
- Mark
PerconaPGBackupasFailed(with a status error) when the cluster is not found or is being deleted duringStarting/Running. - Adjust lease handling and finalizer processing to allow releasing the lease and removing snapshot-related finalizers when the cluster is unavailable/terminating.
- Add a unit test covering failure + finalizer/lease cleanup when the cluster is unavailable (including snapshot mode).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
percona/controller/pgbackup/controller.go |
Detect cluster deletion/unavailability during backup and drive failure + lease/finalizer cleanup paths. |
percona/controller/pgbackup/controller_test.go |
Adds test coverage for failing backups when the cluster is deleted/terminating (including snapshot lease/finalizer cleanup). |
Comment on lines
+72
to
+83
| backup := &v2.PerconaPGBackup{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: "test-backup", | ||
| Namespace: cluster.Namespace, | ||
| Finalizers: []string{pNaming.FinalizerDeleteBackup}, | ||
| }, | ||
| Spec: v2.PerconaPGBackupSpec{ | ||
| PGCluster: cluster.Name, | ||
| RepoName: new("repo1"), | ||
| }, | ||
| Status: v2.PerconaPGBackupStatus{State: v2.BackupRunning}, | ||
| } |
| Status: v2.PerconaPGBackupStatus{State: v2.BackupRunning}, | ||
| } | ||
| if tt.snapshot { | ||
| backup.Spec.Method = new(v2.BackupMethodVolumeSnapshot) |
gkech
reviewed
Jul 22, 2026
Comment on lines
+137
to
+145
| if err := pgBackup.UpdateStatus(ctx, r.Client, func(bcp *v2.PerconaPGBackup) { | ||
| bcp.Status.State = v2.BackupFailed | ||
| bcp.Status.Error = statusError | ||
| }); err != nil { | ||
| return reconcile.Result{}, errors.Wrap(err, "update backup status") | ||
| } | ||
|
|
||
| pgBackup.Status.State = v2.BackupFailed | ||
| pgBackup.Status.Error = statusError |
Contributor
There was a problem hiding this comment.
Seems that we are using this pattern more or less a lot in the codebase, maybe we can introduce something like failBackup(ctx context.Context, pgBackup *v2.PerconaPGBackup, reason string) and reuse it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
Problem:
When a cluster is deleted while a backup is still in progress, the backup remains stuck in the
Runningstate. Instead, it should transition toFailed.Solution:
During backup reconcile, if the cluster is not found or has deletion timestamp, set an active backup as
Failed, release its backup lease, and remove all finalizers.CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability