K8SPSMDB-1213 Add arm64 support for the e2e tests#2379
Open
jvpasinatto wants to merge 22 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the e2e test harness to support running workloads on arm64 nodes (notably on GKE Arm), primarily by injecting kubernetes.io/arch nodeSelectors/tolerations into test manifests and adjusting several test images to be multi-arch friendly.
Changes:
- Add
ARCH-driven architecture scheduling support to e2e workloads (including some auto-detection for GKE Arm-only clusters). - Update multiple e2e manifests/scripts to use explicitly-qualified and/or multi-arch-capable container images.
- Adjust e2e helper logic for helm installs and S3/MinIO checks (AWS CLI runner).
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| e2e-tests/README.md | Document ARCH usage and update documented default image variables. |
| e2e-tests/functions | Core implementation of arch scheduling (manifest transforms, kubectl wrapper, helm args), plus AWS CLI helper refactor. |
| e2e-tests/monitoring-pmm3/run | Add arch-aware helm install parameters for PMM3 server chart. |
| e2e-tests/multi-cluster-service/run | Ensure generated Pod manifest is arch-patched and use a pinned curl image. |
| e2e-tests/multi-cluster-service/conf/some-name.yml | Pin busybox sidecar images to a specific tag. |
| e2e-tests/pitr-sharded/conf/some-name-rs0.yml | Pin busybox sidecar images to a specific tag. |
| e2e-tests/pitr-sharded/conf/eks-some-name-rs0.yml | Pin busybox sidecar images to a specific tag. |
| e2e-tests/pitr-physical/conf/some-name-rs0.yml | Pin busybox sidecar images to a specific tag. |
| e2e-tests/expose-sharded/conf/some-name-rs0.yml | Pin busybox sidecar images to a specific tag. |
| e2e-tests/demand-backup/run | Switch MinIO bucket checks to the shared AWS CLI helper. |
| e2e-tests/demand-backup-sharded/run | Switch MinIO bucket checks to the shared AWS CLI helper. |
| e2e-tests/demand-backup-sharded/conf/some-name-rs0.yml | Pin busybox sidecar images to a specific tag. |
| e2e-tests/init-deploy/conf/another-name-rs0.yml | Pin busybox sidecar images to a specific tag. |
| e2e-tests/ldap/conf/openldap.yaml | Fully-qualify the OpenLDAP image reference. |
| e2e-tests/ldap-tls/conf/openldap.yaml | Fully-qualify the OpenLDAP image reference. |
| e2e-tests/custom-users-roles-sharded/conf/some-name-rs0.yml | Pin busybox sidecar images (but contains an invalid duplicated registry prefix). |
| e2e-tests/conf/cmctl.yml | Use a pinned curl image and download the correct cmctl binary for the container’s architecture. |
| e2e-tests/conf/client.yml | Use a multi-arch PSMDB client image tag. |
| e2e-tests/conf/client_with_tls.yml | Use a multi-arch PSMDB client image tag (TLS variant). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
12 tasks
pull-request-size
Bot
added
size/XL
| local args=("$@") | ||
| local transformed_files=() | ||
|
|
||
| if arch_scheduling_enabled && [[ ${args[0]} == "run" ]]; then |
| fi | ||
| fi | ||
|
|
||
| if arch_scheduling_enabled && [[ ${args[0]} == "apply" ]]; then |
| retry=0 | ||
| echo -n $backup | ||
| until kubectl_bin get cronjob/$backup -o jsonpath='{.status.lastScheduleTime}' 2>/dev/null | grep 'T'; do | ||
| if [[ ${patched} -eq 0 ]] && arch_scheduling_enabled && kubectl_bin get cronjob/$backup >/dev/null 2>&1; then |
Contributor
There was a problem hiding this comment.
This if seems odd to me, shouldn't it finish with ]]?
Comment on lines
+1824
to
+1827
| local args=("$@") | ||
| local transformed_files=() | ||
|
|
||
| if arch_scheduling_enabled && [[ ${args[0]} == "run" ]]; then |
| fi | ||
| fi | ||
|
|
||
| if arch_scheduling_enabled && [[ ${args[0]} == "apply" ]]; then |
valmiranogueira
previously approved these changes
Jun 16, 2026
eleo007
reviewed
Jun 18, 2026
| local args=("$@") | ||
| local transformed_files=() | ||
|
|
||
| if arch_scheduling_enabled && [[ ${args[0]} == "run" ]]; then |
| fi | ||
| fi | ||
|
|
||
| if arch_scheduling_enabled && [[ ${args[0]} == "apply" ]]; then |
Collaborator
commit: 78d57cb |
eleo007
approved these changes
Jun 22, 2026
valmiranogueira
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability