Skip to content

K8SPSMDB-1202 add logs for scheduled backup cleanup #2381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hors merged 7 commits into from
Jun 12, 2026
+2 −1
Merged

K8SPSMDB-1202 add logs for scheduled backup cleanup #2381

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
43235b7
K8SPSMDB-1202 add logs
nmarukovich Jun 4, 2026
af65c5e
K8SPSMDB-1202 fix comment
nmarukovich Jun 9, 2026
979909c
Merge branch 'main' into K8SPSMDB-1202
nmarukovich Jun 10, 2026
82a8217
Merge branch 'main' into K8SPSMDB-1202
nmarukovich Jun 11, 2026
b19d248
Merge branch 'main' into K8SPSMDB-1202
hors Jun 11, 2026
c451228
Merge branch 'main' into K8SPSMDB-1202
hors Jun 11, 2026
99b1037
Merge branch 'main' into K8SPSMDB-1202
hors Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion pkg/controller/perconaservermongodb/backup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,10 +164,16 @@ func (r *ReconcilePerconaServerMongoDB) deleteOldBackupTasks(ctx context.Context
return true
}

if len(oldjobs) > 0 {
log.Info("cleaning up old backups based on retention count",
"job", item.Name, "keep", ret.Count, "toDelete", len(oldjobs))
}

@hors hors Jun 4, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmarukovich please check these comments

@gkech gkech Jun 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeap valid point

@gkech gkech Jun 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have this log when, at the same time we are iterating oldjobs and we generate one log for each old job we have?


for _, todel := range oldjobs {
log.Info("deleting outdated backup", "job", item.Name, "backup", todel.Name)

@gkech gkech Jun 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would't say that these old jobs are outdated, they are not. They are just exceeding retention. Maybe we can say exceeding retention

@gkech gkech Jun 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: deleting backup exceeding retention

err = r.client.Delete(ctx, &todel)
if err != nil {
log.Error(err, "failed to delete backup object")
log.Error(err, "failed to delete backup object", "backup", todel.Name)
Comment on lines 167 to +171
return true
Comment on lines +168 to 172
Comment on lines +168 to 172
Comment on lines +168 to 172
}
}
Expand Down
Loading