Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the operator’s platform reporting to include a detected cloud provider suffix (e.g. kubernetes-gke) so telemetry/version-service requests and startup logs can distinguish between Kubernetes distributions and managed providers.
Changes:
- Add
CloudProvidertoplatform.ServerVersionplus detection via API group probes and a node-sampling fallback. - Switch version-service requests and telemetry metrics to use
serverVersion.String()instead ofserverVersion.Platform. - Update manager startup log to emit the combined platform/provider identifier.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| pkg/platform/platform.go | Adds cloud provider detection and a ServerVersion.String() that returns platform[-cloud]. |
| pkg/version/service/service.go | Sends combined platform/provider string to the version service. |
| pkg/telemetry/service.go | Sends combined platform/provider string as the platform telemetry metric. |
| cmd/manager/main.go | Logs combined platform/provider identifier at startup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
44
to
47
| timeout := 10 * time.Second | ||
| crUID := string(cr.GetUID()) | ||
| platformStr := string(serverVersion.Platform) | ||
| platformStr := serverVersion.String() | ||
|
|
Comment on lines
+123
to
+126
| if strings.Contains(host, aksHostSuffix) { | ||
| log.Info("cloud provider detected", "provider", CloudProviderAKS, "signal", "host:"+aksHostSuffix) | ||
| return CloudProviderAKS | ||
| } |
gkech
marked this pull request as ready for review
June 29, 2026 09:29
gkech
requested review from
mayankshah1607,
nmarukovich,
oksana-grishchenko and
pooknull
as code owners
June 29, 2026 09:29
Comment on lines
44
to
47
| timeout := 10 * time.Second | ||
| crUID := string(cr.GetUID()) | ||
| platformStr := string(serverVersion.Platform) | ||
| platformStr := serverVersion.String() | ||
|
|
Comment on lines
+134
to
+136
| } | ||
| log.Info("cloud provider not detected", "provider", "unknown") | ||
| return CloudProviderUndef |
egegunes
approved these changes
Jun 30, 2026
oksana-grishchenko
approved these changes
Aug 5, 2026
pooknull
approved these changes
Aug 6, 2026
nmarukovich
approved these changes
Aug 12, 2026
mayankshah1607
approved these changes
Sep 1, 2026
Collaborator
commit: 7d919c1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
GKE:
DO:
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability