K8SPS-704 use RestoreBackupSource instead of PerconaServerMySQLBackupStatus - #1507
Merged
Conversation
nmarukovich
marked this pull request as ready for review
August 25, 2026 15:47
nmarukovich
requested review from
egegunes,
gkech,
hors,
mayankshah1607,
oksana-grishchenko and
pooknull
as code owners
August 25, 2026 15:47
egegunes
requested changes
Aug 27, 2026
| apiv1 "github.com/percona/percona-server-mysql-operator/api/v1" | ||
| ) | ||
|
|
||
| func TestGetBackupFromBackupSource(t *testing.T) { |
Contributor
There was a problem hiding this comment.
please add a case for all supported storages
oksana-grishchenko
previously approved these changes
Aug 28, 2026
oksana-grishchenko
left a comment
Contributor
There was a problem hiding this comment.
Note:
this PRs
add new fields to PerconaServerMySQLBackupStatus which currently are propagated to the restore as well because we use the same struct. So depending on the order of merging, your PR or the backup-size PR would need to adopt the changes.
egegunes
approved these changes
Aug 31, 2026
pooknull
approved these changes
Aug 31, 2026
Collaborator
commit: 8cd57e3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
Short explanation of the problem.
PerconaServerMySQLRestoreSpec.BackupSourceis typed asPerconaServerMySQLBackupStatus. A status struct used as spec exposes fields the user can set but that do nothingCause:
Short explanation of the root cause of the issue if applicable.
Solution:
BackupSource now has its own type with the two fields that matter:
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability