Conversation
…ctual latest and minimum supported mysql versions
gkech
marked this pull request as ready for review
September 1, 2026 10:39
gkech
requested review from
eleo007,
jvpasinatto and
valmiranogueira
as code owners
September 1, 2026 10:39
gkech
requested review from
egegunes,
hors,
mayankshah1607,
nmarukovich,
oksana-grishchenko and
pooknull
and
a balanced review from Copilot
September 1, 2026 10:40
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The version substitutions are internally consistent across test inputs, assertions, and version-service fixtures.
Pull request overview
Updates E2E fixtures to exercise currently supported minimum and latest Percona Server versions.
Changes:
- Updates version-service scenarios for MySQL 8.0 and 8.4.
- Updates SmartUpdate coverage from 8.4.8 to 8.4.10.
- Refreshes mocked version-service metadata and hashes.
File summaries
| File | Description |
|---|---|
e2e-tests/tests/version-service/11-create-cluster-80-latest.yaml |
Uses minimum supported 8.0 image. |
e2e-tests/tests/version-service/11-assert.yaml |
Expects latest 8.0 version. |
e2e-tests/tests/version-service/09-create-cluster-80-recommended.yaml |
Uses minimum supported 8.0 image. |
e2e-tests/tests/version-service/09-assert.yaml |
Expects recommended 8.0 version. |
e2e-tests/tests/version-service/07-create-cluster-exact.yaml |
Updates exact-version scenario. |
e2e-tests/tests/version-service/07-assert.yaml |
Expects exact 8.4.8 version. |
e2e-tests/tests/version-service/05-create-cluster-latest.yaml |
Starts latest-policy scenario from 8.4.8. |
e2e-tests/tests/version-service/05-assert.yaml |
Expects latest 8.4.10 version. |
e2e-tests/tests/version-service/03-assert.yaml |
Refreshes disabled-policy expectations. |
e2e-tests/tests/version-service/02-assert.yaml |
Refreshes never-policy expectations. |
e2e-tests/tests/version-service/01-create-cluster-recommended.yaml |
Starts recommended-policy scenario from 8.4.8. |
e2e-tests/tests/version-service/01-assert.yaml |
Expects recommended 8.4.10 version. |
e2e-tests/tests/smart-update/02-check-smart-update.yaml |
Targets 8.4.10 during SmartUpdate. |
e2e-tests/tests/smart-update/01-create-cluster.yaml |
Starts SmartUpdate from 8.4.8. |
e2e-tests/conf/operator.9.9.9.ps-operator.json |
Refreshes mocked versions, images, and hashes. |
Review details
- Files reviewed: 15/15 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
eleo007
approved these changes
Sep 1, 2026
egegunes
approved these changes
Sep 2, 2026
egegunes
left a comment
Contributor
There was a problem hiding this comment.
this is okay for unblocking ourselves but we need to rework these tests to remove the need to update versions
nmarukovich
approved these changes
Sep 2, 2026
pooknull
approved these changes
Sep 2, 2026
Collaborator
commit: bf9a611 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Jira: https://perconadev.atlassian.net/browse/K8SPS-867
Problem:
we have e2e tests that are using mysql version 8.0.28
On our release notes we mention:
Percona Operator for MySQL based on Percona Server for MySQL - Percona Operator for MySQL 1.2.0 (2026-07-03)
smart update:
version service:
Update the tests to use the versions we are currently support, this work most probably should be redone once what we support changes.
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
With this pr, we are adjusting the aforementioned test to use the versions mentioned on the latest operator release.
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability